Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][opensearch] Allow user-defined labels on ingress resource #498

Closed
wigust opened this issue Nov 8, 2023 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@wigust
Copy link
Contributor

wigust commented Nov 8, 2023

Is your feature request related to a problem? Please describe.
The Prometheus Operator allows to create Probes objects automatically for all Ingress objects. The OpenSearch API requires authentication on / and returns 401, which triggers alerts by default (not HTTP code 200-399).

Describe the solution you'd like
Labels could be used in kube-prometheus-stack monitoring.coreos.com/v1 Probe objects as a selector to disable creating probe for the OpenSearch Ingress.

Describe alternatives you've considered
Configure Blackbox exporter for authenticated connections to OpenSearch API.

Additional context
Similar to #394 Ingress labels could be used for other things, e.g. external-dns.

Pull request adding this feature is available at #497

@wigust wigust added enhancement New feature or request untriaged Issues that have not yet been triaged labels Nov 8, 2023
wigust added a commit to wigust/opensearch-project-helm-charts that referenced this issue Nov 8, 2023
@opencmit2
Copy link

Hi @wigust
The configuration .Values.labels can also be used to add custom labels.

@peterzhuamazon peterzhuamazon removed the untriaged Issues that have not yet been triaged label Dec 5, 2023
wigust added a commit to wigust/opensearch-project-helm-charts that referenced this issue Dec 14, 2023
wigust added a commit to wigust/opensearch-project-helm-charts that referenced this issue Dec 14, 2023
@wigust
Copy link
Contributor Author

wigust commented Dec 14, 2023

Hi @opencmit2

Apologies for the slow response.

The configuration .Values.labels can also be used to add custom labels.

It can, but as described in the pull request - it triggers to restart all OpenSearch pods which is too costly for the case of adding a label to ingress.

@wigust
Copy link
Contributor Author

wigust commented Apr 28, 2024

Merged in #497

Thank you for adding this feature!

@wigust wigust closed this as completed Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants