Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI pipeline update to publish geospatial-client jar #706

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andy-k-improving
Copy link
Contributor

@andy-k-improving andy-k-improving commented Dec 18, 2024

Description

To update the project setup, in order to publish geospatial-client jar for both snapshot and release version into aws.oss.sonatype.org during the CI execution with appropriate credential.

Related Issues

Resolves #698

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Testplan

# Publish the client Jar into local .m2 and examine the jar. 
gradle :geospatial-client:publishNebulaPublicationToMavenLocal 

Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
@andy-k-improving
Copy link
Contributor Author

@heemin32 I have checked on the existing pipeline, but I don't see any release logic for publishing production zip || jar.
Wonder is that published separately on AWS side?

@andy-k-improving
Copy link
Contributor Author

@heemin32 @navneet1v Any thought?

@heemin32
Copy link
Collaborator

@heemin32 I have checked on the existing pipeline, but I don't see any release logic for publishing production zip || jar. Wonder is that published separately on AWS side?

Are you talking about something like this? https://github.com/opensearch-project/opensearch-build

@andy-k-improving
Copy link
Contributor Author

andy-k-improving commented Dec 20, 2024

@heemin32 yes, thanks for the reference, let me look into that.
In the meanwhile would that be possible to test this change on Github runner before merging?
Can we somehow trigger the build and publish snapshot workflow here, or we can only test it upon merging to main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Expose Geo2IP Enrichment feature to other plugins to standardize OpenSearch IP enrichment offering
2 participants