Revert datasource state when delete fails #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
added
bug
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Signed-off-by: Heemin Kim <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #382 +/- ##
============================================
+ Coverage 88.41% 88.70% +0.28%
- Complexity 751 753 +2
============================================
Files 92 92
Lines 2711 2718 +7
Branches 220 221 +1
============================================
+ Hits 2397 2411 +14
+ Misses 233 228 -5
+ Partials 81 79 -2
|
| try { | ||
| geoIpDataDao.deleteIp2GeoDataIndex(datasource.getIndices()); | ||
| } catch (Exception e) { | ||
| if (previousState.equals(datasource.getState()) == false) { |
There was a problem hiding this comment.
what is the scenario when datasource has previous state? We're setting it to "deleting" before we call delete method in setDatasourceStateAsDeleting().
There was a problem hiding this comment.
We first change the datasource state to "deleting" and run the delete process. So, datasource always has previous state either "available", "create_failed", or "deleting".
There was a problem hiding this comment.
Got more info on scenario, we need to delete two resources(index and metadata), if we fail to delete metadata, we don’t revert state because index for data is already deleted
martin-gaievski
approved these changes
Aug 15, 2023
junqiu-lei
approved these changes
Aug 16, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit f4514c1)
heemin32
added a commit
that referenced
this pull request
Aug 17, 2023
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit f4514c1) Co-authored-by: Heemin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert datasource state when delete fails
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.