Add limit to geojson upload API #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
approved these changes
Feb 9, 2023
| @@ -61,9 +64,28 @@ public static UploadGeoJSONRequestContent create(Map<String, Object> input) { | |||
| geoJSONData + " is not an instance of List, but of type [ " + geoJSONData.getClass().getName() + " ]" | |||
| ); | |||
| } | |||
| final long featureCount = getFeatureCount(geoJSONData); | |||
| if (featureCount > MAX_SUPPORTED_GEOJSON_FEATURE_COUNT) { | |||
There was a problem hiding this comment.
Do you want to add a comment here that why we are setting the max limit to 10_000?
There was a problem hiding this comment.
i added comment close to constant
| @@ -61,9 +64,28 @@ public static UploadGeoJSONRequestContent create(Map<String, Object> input) { | |||
| geoJSONData + " is not an instance of List, but of type [ " + geoJSONData.getClass().getName() + " ]" | |||
| ); | |||
| } | |||
| final long featureCount = getFeatureCount(geoJSONData); | |||
| if (featureCount > MAX_SUPPORTED_GEOJSON_FEATURE_COUNT) { | |||
There was a problem hiding this comment.
Also, can we break this down into a separate method like validateFeatureCount(geoJSONData) { ....} ?
Will limit upto 10_000 features to upload. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
add-limit-to-upload
branch
from
ed87490 to
d7656cf
Compare
martin-gaievski
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upload API will limit number of features to be uploaded to 10_000. Since custom vector map will allow 10K documents to
be fetched, we will add same constraint while upload for consistency .
Signed-off-by: Vijayan Balasubramanian [email protected]
Issues Resolved
opensearch-project/dashboards-maps#220
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.