Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency org.apache.httpcomponents.core5:httpcore5 to v5.3.1 #926

Conversation

mend-for-github.aaakk.us.kg[bot]
Copy link
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.apache.httpcomponents.core5:httpcore5 5.3 -> 5.3.1 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (ad8a033) to head (b36b7fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #926   +/-   ##
=========================================
  Coverage     78.07%   78.07%           
  Complexity      996      996           
=========================================
  Files            99       99           
  Lines          4625     4625           
  Branches        431      431           
=========================================
  Hits           3611     3611           
  Misses          834      834           
  Partials        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19
Copy link
Member

@dbwiddis the build passed but I see the forced version is getting updated here. Are we fine to merge this?

…5 to v5.3.1

Signed-off-by: mend-for-github.aaakk.us.kg[bot] <mend-for-github.aaakk.us.kg[bot]@users.noreply.github.com>
@mend-for-github.aaakk.us.kg mend-for-github.aaakk.us.kg bot force-pushed the whitesource-remediate/org.apache.httpcomponents.core5-httpcore5-5.x branch from 7287016 to b36b7fd Compare October 22, 2024 17:43
@dbwiddis
Copy link
Member

@dbwiddis the build passed but I see the forced version is getting updated here. Are we fine to merge this?

Yeah, patch version bump and the force is just to prevent jar hell.

@dbwiddis dbwiddis merged commit 5647132 into main Oct 22, 2024
20 checks passed
@dbwiddis dbwiddis deleted the whitesource-remediate/org.apache.httpcomponents.core5-httpcore5-5.x branch October 22, 2024 17:53
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-926-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5647132d4a7a175bf864d867bec9b8204154a1ce
# Push it to GitHub
git push --set-upstream origin backport/backport-926-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-926-to-2.x.

@dbwiddis
Copy link
Member

We don't have this dependency on 2.x, should not have attempted backport. :)

@dbwiddis dbwiddis removed the backport 2.x backport PRs to 2.x branch label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants