Quick fix for flaky integ test reprovisioning before template update #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added
backport 2.x
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
=========================================
Coverage 77.55% 77.55%
Complexity 966 966
=========================================
Files 97 97
Lines 4531 4531
Branches 422 422
=========================================
Hits 3514 3514
Misses 835 835
Partials 182 182 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Sep 24, 2024
jackiehanyang
approved these changes
Sep 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
…880) Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 22c994b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
…880) Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 22c994b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Sep 24, 2024
…template update (#882) Quick fix for flaky integ test reprovisioning before template update (#880) (cherry picked from commit 22c994b) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Sep 24, 2024
…emplate update (#881) Quick fix for flaky integ test reprovisioning before template update (#880) (cherry picked from commit 22c994b) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saimedhi
added a commit
to saimedhi/flow-framework
that referenced
this pull request
Oct 22, 2024
…n tests Signed-off-by: saimedhi <[email protected]>
5 tasks
dbwiddis
pushed a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: saimedhi <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: saimedhi <[email protected]> (cherry picked from commit 79bd859) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Nov 7, 2024
…ests (#931) Revert PR #880: Remove temporary fix for integration tests (#930) (cherry picked from commit 79bd859) Signed-off-by: saimedhi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick fix for flaky integ test, to reduce retry churn for 2.17.1 release.
Related Issues
Temporary workaround for #870. Needs a better permanent fix where we can just test the completed state and be assured the template is also updated.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.