Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query assist data summary agent template #875

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

chishui
Copy link
Contributor

@chishui chishui commented Sep 18, 2024

Description

Add query assist data summary agent template

Related Issues

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Sep 18, 2024
Signed-off-by: Liyun Xiu <[email protected]>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.55%. Comparing base (2513d49) to head (a17492f).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #875   +/-   ##
=========================================
  Coverage     77.55%   77.55%           
  Complexity      966      966           
=========================================
  Files            97       97           
  Lines          4531     4531           
  Branches        422      422           
=========================================
  Hits           3514     3514           
  Misses          835      835           
  Partials        182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chishui chishui marked this pull request as ready for review September 18, 2024 07:23
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a change log entry!

Signed-off-by: Liyun Xiu <[email protected]>
@chishui
Copy link
Contributor Author

chishui commented Sep 19, 2024

LGTM. Please add a change log entry!

Added

@chishui
Copy link
Contributor Author

chishui commented Sep 30, 2024

@dbwiddis could you help merge this PR? Thanks

@dbwiddis
Copy link
Member

@dbwiddis could you help merge this PR? Thanks

I've approved already. It takes two approvals. :)

We have a while before the next release, there is no rush.

@owaiskazi19 owaiskazi19 merged commit c1f5519 into opensearch-project:main Sep 30, 2024
20 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-875-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c1f5519fa7e5292d63bfc9afb38b475306b0a576
# Push it to GitHub
git push --set-upstream origin backport/backport-875-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-875-to-2.x.

dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Oct 21, 2024
* Add query assist data summary agent template

Signed-off-by: Liyun Xiu <[email protected]>

* spotlessApply

Signed-off-by: Liyun Xiu <[email protected]>

* Add changelog

Signed-off-by: Liyun Xiu <[email protected]>

---------

Signed-off-by: Liyun Xiu <[email protected]>
dbwiddis added a commit that referenced this pull request Oct 22, 2024
)

Add query assist data summary agent template (#875)

* Add query assist data summary agent template



* spotlessApply



* Add changelog



---------

Signed-off-by: Liyun Xiu <[email protected]>
Co-authored-by: Liyun Xiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants