Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adds reprovision API to support updating search pipelines, ingest pipelines index settings #824

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 48c7019 from #804.

…elines index settings (#804)

* Initial commit, Adds ReprovisionWorkflowTransportAction, reprovision param for RestCreateWorkflowAction, creates and registers Update Ingest/Search pipeline steps in WorkflowResources, registers update steps in WorkflowStepFactory

Signed-off-by: Joshua Palis <[email protected]>

* Initial reprovisiontransportaction implementation, Added UpdateIndexStep, improved WorkflowProcessSorter.createReprovisionSequence

Signed-off-by: Joshua Palis <[email protected]>

* Implements Update index Step to support updating index settings, modifies updating resource created script to remove error if any

Signed-off-by: Joshua Palis <[email protected]>

* Improves workflow node comparision

Signed-off-by: Joshua Palis <[email protected]>

* Adding comments

Signed-off-by: Joshua Palis <[email protected]>

* Fixing tests, adding javadocs

Signed-off-by: Joshua Palis <[email protected]>

* Adding changelog

Signed-off-by: Joshua Palis <[email protected]>

* Updating parse utils, RestCreateWorkflowAction, CreateWorkflowTransportAction tests. Adding check for reprovision without workflowID.

Signed-off-by: Joshua Palis <[email protected]>

* Adding update step and get resource step tests

Signed-off-by: Joshua Palis <[email protected]>

* Adding check for filtered setting list size

Signed-off-by: Joshua Palis <[email protected]>

* Addign reprovision workflow transport action tests

Signed-off-by: Joshua Palis <[email protected]>

* Adding tests for reprovision sequence creation

Signed-off-by: Joshua Palis <[email protected]>

* Addressing comments

Signed-off-by: Joshua Palis <[email protected]>

* Changing GetResourceStep to WorkflowDataStep

Signed-off-by: Joshua Palis <[email protected]>

* Addressing PR comments

Signed-off-by: Joshua Palis <[email protected]>

* Fixing state check for reprovision transport action

Signed-off-by: Joshua Palis <[email protected]>

* Adding state eror check to reprovision transport action to remove error field

Signed-off-by: Joshua Palis <[email protected]>

* removing error check from flowframeworkindices handler

Signed-off-by: Joshua Palis <[email protected]>

* Adding check for no updated settings

Signed-off-by: Joshua Palis <[email protected]>

* refactor reprovision sequence creation

Signed-off-by: Joshua Palis <[email protected]>

* Fixing workflowrequest serialization

Signed-off-by: Joshua Palis <[email protected]>

* Addressing PR comments

Signed-off-by: Joshua Palis <[email protected]>

* Moving flattenSettings method to ParseUtils, added flatten settings tests

Signed-off-by: Joshua Palis <[email protected]>

* updating workflowrequest

Signed-off-by: Joshua Palis <[email protected]>

* fixing workflowrequest

Signed-off-by: Joshua Palis <[email protected]>

* spotlessApply

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 48c7019)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 72.59101% with 128 lines in your changes missing coverage. Please review.

Project coverage is 75.38%. Comparing base (174a417) to head (fce2f9d).

Files Patch % Lines
.../transport/ReprovisionWorkflowTransportAction.java 46.21% 70 Missing and 1 partial ⚠️
...search/flowframework/workflow/UpdateIndexStep.java 73.01% 16 Missing and 1 partial ⚠️
...ework/transport/CreateWorkflowTransportAction.java 73.91% 10 Missing and 2 partials ⚠️
.../flowframework/workflow/WorkflowProcessSorter.java 83.07% 6 Missing and 5 partials ⚠️
...earch/flowframework/transport/WorkflowRequest.java 66.66% 2 Missing and 4 partials ⚠️
...search/flowframework/common/WorkflowResources.java 82.75% 2 Missing and 3 partials ⚠️
...h/flowframework/rest/RestCreateWorkflowAction.java 69.23% 2 Missing and 2 partials ⚠️
...ramework/transport/ReprovisionWorkflowRequest.java 94.73% 1 Missing ⚠️
...framework/workflow/AbstractUpdatePipelineStep.java 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #824      +/-   ##
============================================
- Coverage     75.82%   75.38%   -0.45%     
- Complexity      838      917      +79     
============================================
  Files            88       96       +8     
  Lines          4054     4456     +402     
  Branches        373      412      +39     
============================================
+ Hits           3074     3359     +285     
- Misses          824      925     +101     
- Partials        156      172      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshpalis joshpalis merged commit 9d49aea into 2.x Aug 5, 2024
31 checks passed
@joshpalis joshpalis deleted the backport/backport-804-to-2.x branch August 5, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant