-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw the correct error message in status API for WorkflowSteps #676
Throw the correct error message in status API for WorkflowSteps #676
Conversation
2124797
to
532a326
Compare
532a326
to
3316d66
Compare
src/main/java/org/opensearch/flowframework/exception/WorkflowStepException.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/exception/WorkflowStepException.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java
Show resolved
Hide resolved
Can you test case of how exception looks like when there is unsafe exception like remotetransportexception, when you deploy multiple models at the same time. Also can we also add this to create index step, along with changing CreateIndexStep line here to workflowstepexception https://github.com/opensearch-project/flow-framework/blob/main/src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java#L142 |
Added 2 tests for CreateIndex and RegisterRemoteStep
Done |
246a5a1
to
7a1845a
Compare
…ect#680) * Hide user and credential field from search response Signed-off-by: Owais Kazi <[email protected]> * Hid the user field for Get API as well Signed-off-by: Owais Kazi <[email protected]> * Addressed PR Comments Signed-off-by: Owais Kazi <[email protected]> * Added user permission and new tests Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
7a1845a
to
3a18915
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Owais Kazi <[email protected]>
1aea3f0
to
2a77791
Compare
* Hides user and credential field from search response (#680) * Hide user and credential field from search response Signed-off-by: Owais Kazi <[email protected]> * Hid the user field for Get API as well Signed-off-by: Owais Kazi <[email protected]> * Addressed PR Comments Signed-off-by: Owais Kazi <[email protected]> * Added user permission and new tests Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> * Addressed PR Comments Signed-off-by: Owais Kazi <[email protected]> * Fixed failing test Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit 56e4a78) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…flowSteps (#683) Throw the correct error message in status API for WorkflowSteps (#676) * Hides user and credential field from search response (#680) * Hide user and credential field from search response * Hid the user field for Get API as well * Addressed PR Comments * Added user permission and new tests --------- * Addressed PR Comments * Fixed failing test --------- (cherry picked from commit 56e4a78) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Throw the correct error message in status API for WorkflowSteps. As called out in the issue, exceptions added in
getException
method are safe exceptions to be shown in status API.Few examples:
Issues Resolved
Resolves #670
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.