Reset workflow state to initial state after successful deprovision #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
============================================
- Coverage 72.36% 72.33% -0.04%
Complexity 680 680
============================================
Files 82 82
Lines 3532 3528 -4
Branches 284 284
============================================
- Hits 2556 2552 -4
Misses 850 850
Partials 126 126 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Widdis <[email protected]>
joshpalis
approved these changes
Apr 2, 2024
ohltyler
approved these changes
Apr 2, 2024
Signed-off-by: Daniel Widdis <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
) Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 33ea800) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amitgalitz
pushed a commit
that referenced
this pull request
Apr 2, 2024
… deprovision (#643) Reset workflow state to initial state after successful deprovision (#635) (cherry picked from commit 33ea800) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amitgalitz
reviewed
Apr 2, 2024
| @@ -246,7 +242,7 @@ private void updateWorkflowState( | |||
| Map.ofEntries( | |||
| Map.entry(STATE_FIELD, State.COMPLETED), | |||
| Map.entry(PROVISIONING_PROGRESS_FIELD, ProvisioningProgress.DONE), | |||
| Map.entry(PROVISION_START_TIME_FIELD, Instant.now().toEpochMilli()), | |||
| Map.entry(PROVISION_END_TIME_FIELD, Instant.now().toEpochMilli()), | |||
There was a problem hiding this comment.
is there a new provision end time when we fail deprovisioning? Is the end time here not when the provisioning itself ends (last step is executed), unrelated to deprovisioning? cc: @dbwiddis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On successful deprovision, resets the workflow state to its initial state, rather than simply updating the fields.
Issues Resolved
Fixes #578
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.