Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Refactored logging for consistency #547

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7cdbd3f from #524.

* Remove stack traces and exception causes from logs

Signed-off-by: Daniel Widdis <[email protected]>

* Logs no longer reveal transport action names

Signed-off-by: Daniel Widdis <[email protected]>

* Rebase, remove unused param and logger, typo fix

Signed-off-by: Daniel Widdis <[email protected]>

* Add logging for all client Transport calls

Signed-off-by: Daniel Widdis <[email protected]>

* Add back stack traces in error logging for failed transport queries

Signed-off-by: Daniel Widdis <[email protected]>

* Add back in stack traces for other error messages outside transport

Signed-off-by: Daniel Widdis <[email protected]>

* Add id and other details to workflow step error messages

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit 7cdbd3f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 43.18182% with 200 lines in your changes are missing coverage. Please review.

Project coverage is 72.98%. Comparing base (1335d4a) to head (75ec431).

Files Patch % Lines
...framework/indices/FlowFrameworkIndicesHandler.java 23.25% 33 Missing ⚠️
...ework/transport/CreateWorkflowTransportAction.java 45.00% 20 Missing and 2 partials ⚠️
...lowframework/workflow/RegisterRemoteModelStep.java 20.00% 12 Missing ⚠️
...ork/transport/GetWorkflowStateTransportAction.java 8.33% 11 Missing ⚠️
...search/flowframework/workflow/CreateIndexStep.java 21.42% 11 Missing ⚠️
...owframework/workflow/CreateIngestPipelineStep.java 21.42% 11 Missing ⚠️
...rk/transport/ProvisionWorkflowTransportAction.java 41.17% 10 Missing ⚠️
...ch/flowframework/workflow/CreateConnectorStep.java 28.57% 10 Missing ⚠️
...mework/workflow/AbstractRetryableWorkflowStep.java 18.18% 9 Missing ⚠️
.../transport/DeprovisionWorkflowTransportAction.java 20.00% 8 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #547      +/-   ##
============================================
- Coverage     73.83%   72.98%   -0.85%     
+ Complexity      663      662       -1     
============================================
  Files            79       79              
  Lines          3314     3395      +81     
  Branches        263      264       +1     
============================================
+ Hits           2447     2478      +31     
- Misses          752      803      +51     
+ Partials        115      114       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit b19ed30 into 2.x Feb 28, 2024
27 of 28 checks passed
@dbwiddis dbwiddis deleted the backport/backport-524-to-2.x branch February 28, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant