Fixed response of Deploy Model Step #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
previously approved these changes
Feb 17, 2024
owaiskazi19
force-pushed
the
fix-response
branch
from
666d901 to
e5a3996
Compare
dbwiddis
approved these changes
Feb 17, 2024
src/main/java/org/opensearch/flowframework/workflow/DeployModelStep.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
fix-response
branch
from
e5a3996 to
e54107f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
============================================
- Coverage 72.12% 72.11% -0.02%
Complexity 624 624
============================================
Files 78 78
Lines 3161 3159 -2
Branches 239 239
============================================
- Hits 2280 2278 -2
Misses 776 776
Partials 105 105 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Feb 17, 2024
amitgalitz
approved these changes
Feb 17, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-527-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b25790f6940322a5f10dc8db3d0e71b687452f4a
# Push it to GitHub
git push --set-upstream origin backport/backport-527-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.xThen, create a pull request where the |
owaiskazi19
added a commit
to owaiskazi19/opensearch-ai-flow-framework
that referenced
this pull request
Feb 19, 2024
* Fixed response of Deploy Model Step Signed-off-by: Owais Kazi <[email protected]> * Fixed test Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit b25790f)
joshpalis
pushed a commit
that referenced
this pull request
Feb 19, 2024
Fixed response of Deploy Model Step (#527) * Fixed response of Deploy Model Step Signed-off-by: Owais Kazi <[email protected]> * Fixed test Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit b25790f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed response of Deploy Model Step. Fixed Dev guide. Removed an extra NoopStep from the stepMap.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.