Use full access client for FlowFrameworkSecureRestApiIT #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=========================================
Coverage 71.91% 71.91%
Complexity 621 621
=========================================
Files 78 78
Lines 3133 3133
Branches 234 234
=========================================
Hits 2253 2253
Misses 776 776
Partials 104 104 ☔ View full report in Codecov by Sentry. |
|
This is obviously not the correct solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
FlowFrameworkSecureRestApiITinherits fromFlowFrameworkRestTestCase. TheadminClient()inherited fromOpenSearchRestTestCasedoes not have the correct configuration for a secure cluster.This change creates an instance variable for the
adminClientthat is replaced by the properly configured full access client.Issues Resolved
Fixes #469
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.