Prevent provisioning an already-provisioned workflow #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
============================================
+ Coverage 71.72% 71.84% +0.12%
- Complexity 619 622 +3
============================================
Files 78 78
Lines 3126 3136 +10
Branches 236 236
============================================
+ Hits 2242 2253 +11
Misses 776 776
+ Partials 108 107 -1 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Jan 29, 2024
Signed-off-by: Daniel Widdis <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
* Prevent provisioning an already-provisioned workflow Signed-off-by: Daniel Widdis <[email protected]> * Don't provision on failed state index update Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 5d452f3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 29, 2024
…468) Prevent provisioning an already-provisioned workflow (#466) * Prevent provisioning an already-provisioned workflow * Don't provision on failed state index update --------- (cherry picked from commit 5d452f3) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents provisioning a workflow whose state is anything other than NOT_STARTED.
Clarified some associated method/variable naming.
Issues Resolved
Fixes #445
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.