Retry deprovisioning integ test on 202 return #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
============================================
- Coverage 71.88% 71.72% -0.16%
+ Complexity 620 619 -1
============================================
Files 78 78
Lines 3126 3126
Branches 236 236
============================================
- Hits 2247 2242 -5
- Misses 772 776 +4
- Partials 107 108 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
improve-integ
branch
from
5894a34 to
5478fa0
Compare
joshpalis
approved these changes
Jan 26, 2024
I think we only need to "test" the deprovisioning once. If you want to just always execute the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Retry deprovisioning on 202 return Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit f4fa29e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Jan 26, 2024
Retry deprovisioning integ test on 202 return (#457) Retry deprovisioning on 202 return (cherry picked from commit f4fa29e) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By design, the deprovision API makes a best effort at deprovisioning. Some deprovisioning may take longer than twice the 1 second delay between retries, which results in a 202 error to the user indicating which resources were not deprovisioned (yet). Rerunning the API in this case works after a few more seconds.
Updating the deprovisioning test to do a wait-and-retry in this edge case (which seems to happen on macOS frequently and Windows rarely).
Issues Resolved
Fixes the most recent flaky tests
https://github.com/opensearch-project/flow-framework/actions/runs/7659934815
https://github.com/opensearch-project/flow-framework/actions/runs/7659475132
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.