Excluded integTest from build script to handle the security plugin dependency

[owaiskazi19]

Description

Excluded integTest from build script to handle the security plugin dependency.

Refer opensearch-project/neural-search#543 for more details.

Issues Resolved

Fixes #410

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (789fc4d) 71.85% compared to head (cb91013) 71.85%.

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #418   +/-   ##
=========================================
  Coverage     71.85%   71.85%           
  Complexity      614      614           
=========================================
  Files            79       79           
  Lines          3084     3084           
  Branches        237      237           
=========================================
  Hits           2216     2216           
  Misses          763      763           
  Partials        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[prudhvigodithi]

Hey @owaiskazi19 instead of new secureIntegTestPluginArchive configuration, I assume just changing the if statement to if(it.name.contains("opensearch-security")) should work. Can you please check?

[owaiskazi19]

@prudhvigodithi here we have to install all the plugins except security plugin. zipArchive would have security plugin in it.

[vibrantvarun]

Yes, +1 to @owaiskazi19 . Initially we kept it how @prudhvigodithi you mentioned above. But the problem, here we just need security plugin to run integ tests, therefore zip archive tries to find it at the compile time also. Therefore, we need to change the tag to securePluginTestArchive

[prudhvigodithi]

Thanks @vibrantvarun and @owaiskazi19 I'm afraid introducing new configuration secureIntegTestPluginArchive might never be called. Also I noticed the logic is called in ext (extra properties) where as I see similar code in integTest, If not needed we can completely remove the in ext.

testClusters.integTest {
    testDistribution = "ARCHIVE"

    // Optionally install security
    if (System.getProperty("security.enabled") != null && System.getProperty("security.enabled") == "true") {
        configureSecurityPlugin(testClusters.integTest)
    }

    // Installs all registered zipArchive dependencies on integTest cluster nodes except security
    configurations.zipArchive.asFileTree.each {
            plugin(provider(new Callable<RegularFile>(){
                    @Override
                    RegularFile call() throws Exception {
                        return new RegularFile() {
                            @Override
                            File getAsFile() {
                                return it
                            }
                        }
                    }
                })
            )

    }