Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] GET API to fetch workflow-step.json #397

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ebf8b90 from #394.

* Implemented GET API for workflow step

Signed-off-by: Owais Kazi <[email protected]>

* Added rest test case

Signed-off-by: Owais Kazi <[email protected]>

* Added tests and javadocs

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments

Signed-off-by: Owais Kazi <[email protected]>

* Removed CreateIndex and CreateIngestPipeline from json

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit ebf8b90)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (25f312b) 73.04% compared to head (25ec4da) 72.17%.

Files Patch % Lines
...rch/flowframework/model/WorkflowStepValidator.java 0.00% 19 Missing ⚠️
.../flowframework/rest/RestGetWorkflowStepAction.java 50.00% 14 Missing ⚠️
...owframework/transport/GetWorkflowStepResponse.java 33.33% 6 Missing ⚠️
...nsearch/flowframework/model/WorkflowValidator.java 0.00% 5 Missing ⚠️
...work/transport/GetWorkflowStepTransportAction.java 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #397      +/-   ##
============================================
- Coverage     73.04%   72.17%   -0.88%     
- Complexity      602      613      +11     
============================================
  Files            75       79       +4     
  Lines          2998     3069      +71     
  Branches        233      237       +4     
============================================
+ Hits           2190     2215      +25     
- Misses          706      752      +46     
  Partials        102      102              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19 owaiskazi19 merged commit a37e83b into 2.x Jan 10, 2024
14 of 15 checks passed
@owaiskazi19 owaiskazi19 deleted the backport/backport-394-to-2.x branch January 10, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant