[Feature/agent_framework] Fetches modelID for RegisterAgent and Tools workflow steps #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
joshpalis
approved these changes
Dec 1, 2023
src/main/java/org/opensearch/flowframework/workflow/RegisterAgentStep.java
Show resolved
Hide resolved
dbwiddis
approved these changes
Dec 1, 2023
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
parse-agent
branch
from
0fc58b1 to
11cb3ed
Compare
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
merged commit 8dd6ca8
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
… workflow steps (opensearch-project#235) * Flattened llm field of register agent Signed-off-by: Owais Kazi <[email protected]> * Handled optional modelId Signed-off-by: Owais Kazi <[email protected]> * Handled modelId for llm Signed-off-by: Owais Kazi <[email protected]> * Parsing for parameters field of tools Signed-off-by: Owais Kazi <[email protected]> * Handled test case failures Signed-off-by: Owais Kazi <[email protected]> * Fixed spotless failure Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
… workflow steps (#235) * Flattened llm field of register agent Signed-off-by: Owais Kazi <[email protected]> * Handled optional modelId Signed-off-by: Owais Kazi <[email protected]> * Handled modelId for llm Signed-off-by: Owais Kazi <[email protected]> * Parsing for parameters field of tools Signed-off-by: Owais Kazi <[email protected]> * Handled test case failures Signed-off-by: Owais Kazi <[email protected]> * Fixed spotless failure Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
… workflow steps (opensearch-project#235) * Flattened llm field of register agent Signed-off-by: Owais Kazi <[email protected]> * Handled optional modelId Signed-off-by: Owais Kazi <[email protected]> * Handled modelId for llm Signed-off-by: Owais Kazi <[email protected]> * Parsing for parameters field of tools Signed-off-by: Owais Kazi <[email protected]> * Handled test case failures Signed-off-by: Owais Kazi <[email protected]> * Fixed spotless failure Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
… workflow steps (#235) * Flattened llm field of register agent Signed-off-by: Owais Kazi <[email protected]> * Handled optional modelId Signed-off-by: Owais Kazi <[email protected]> * Handled modelId for llm Signed-off-by: Owais Kazi <[email protected]> * Parsing for parameters field of tools Signed-off-by: Owais Kazi <[email protected]> * Handled test case failures Signed-off-by: Owais Kazi <[email protected]> * Fixed spotless failure Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
… workflow steps (opensearch-project#235) * Flattened llm field of register agent Signed-off-by: Owais Kazi <[email protected]> * Handled optional modelId Signed-off-by: Owais Kazi <[email protected]> * Handled modelId for llm Signed-off-by: Owais Kazi <[email protected]> * Parsing for parameters field of tools Signed-off-by: Owais Kazi <[email protected]> * Handled test case failures Signed-off-by: Owais Kazi <[email protected]> * Fixed spotless failure Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
… workflow steps (opensearch-project#235) * Flattened llm field of register agent Signed-off-by: Owais Kazi <[email protected]> * Handled optional modelId Signed-off-by: Owais Kazi <[email protected]> * Handled modelId for llm Signed-off-by: Owais Kazi <[email protected]> * Parsing for parameters field of tools Signed-off-by: Owais Kazi <[email protected]> * Handled test case failures Signed-off-by: Owais Kazi <[email protected]> * Fixed spotless failure Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the below:
parametersfield ofllmby flattening it. Fetchesmodel_idforparametersfield of RegisterAgentStep if not provided by user and present in previous node inputs.Ref: this and this
model_idforparametersfield of ToolStep if not provided by user and present in previous node inputs.Ref: this and this.
Issues Resolved
Part of #194
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.