Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport Feature/agent_framework] Manual Backport #204

Merged

Conversation

joshpalis
Copy link
Member

@joshpalis joshpalis commented Nov 28, 2023

Description

Manual Backport of

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Palis <[email protected]>
- name: Upload Coverage Report
if: matrix.os == 'ubuntu-latest'
uses: codecov/codecov-action@v3
with:
file: ./build/reports/jacoco/test/jacocoTestReport.xml
file: ./build/reports/jacoco/test/jacocoTestReport.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to make any changes in the CI file here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed most of the modifications except for the spotless modification of #175

Signed-off-by: Joshua Palis <[email protected]>
@@ -41,9 +46,9 @@ jobs:
- uses: actions/checkout@v4
- name: Build and Run Tests
run: |
./gradlew check
./gradlew check -x integTest -x yamlRestTest -x spotlessJava
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make run the complete gradle check suite temporary. Ref: https://github.com/opensearch-project/flow-framework/pull/169/files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I'll go ahead and omit this modification to the CI.yml

Signed-off-by: Joshua Palis <[email protected]>
@joshpalis
Copy link
Member Author

Will wait until the checks have passed before merging this manual backport PR into the branch.

@joshpalis
Copy link
Member Author

Failed with

> Task :spotlessJava FAILED
Step 'eclipse jdt formatter' found problem in 'src/main/java/org/opensearch/flowframework/common/CommonValue.java':
You are running Spotless on JVM 11, which limits you to eclipse jdt formatter 4.26.
If you upgrade your JVM to 17+, then you can use eclipse jdt formatter 4.27, which may have fixed this problem.
java.lang.Exception: You are running Spotless on JVM 11, which limits you to eclipse jdt formatter 4.26.
If you upgrade your JVM to 17+, then you can use eclipse jdt formatter 4.27, which may have fixed this problem.

Reverting all changes to the CI.yml

@joshpalis
Copy link
Member Author

Note : the security check will fail if we omit the CI.yml/build.gradle modifications of PR #175 , however since this is just a temporary branch until feature/agent_framework on ML commons is merged to main, this is an acceptable failure

@joshpalis joshpalis merged commit 9c85bdd into opensearch-project:feature/agent_framework Nov 28, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants