-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport Feature/agent_framework] Manual Backport #204
[Backport Feature/agent_framework] Manual Backport #204
Conversation
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
.github/workflows/CI.yml
Outdated
- name: Upload Coverage Report | ||
if: matrix.os == 'ubuntu-latest' | ||
uses: codecov/codecov-action@v3 | ||
with: | ||
file: ./build/reports/jacoco/test/jacocoTestReport.xml | ||
file: ./build/reports/jacoco/test/jacocoTestReport.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to make any changes in the CI file here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed most of the modifications except for the spotless modification of #175
Signed-off-by: Joshua Palis <[email protected]>
.github/workflows/CI.yml
Outdated
@@ -41,9 +46,9 @@ jobs: | |||
- uses: actions/checkout@v4 | |||
- name: Build and Run Tests | |||
run: | | |||
./gradlew check | |||
./gradlew check -x integTest -x yamlRestTest -x spotlessJava |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make run the complete gradle check suite temporary. Ref: https://github.com/opensearch-project/flow-framework/pull/169/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I'll go ahead and omit this modification to the CI.yml
Signed-off-by: Joshua Palis <[email protected]>
Will wait until the checks have passed before merging this manual backport PR into the branch. |
Signed-off-by: Joshua Palis <[email protected]>
Failed with
Reverting all changes to the CI.yml |
Signed-off-by: Joshua Palis <[email protected]>
Note : the security check will fail if we omit the CI.yml/build.gradle modifications of PR #175 , however since this is just a temporary branch until |
9c85bdd
into
opensearch-project:feature/agent_framework
Description
Manual Backport of
Force newer version of transitive (spotless) eclipse dependency #175- incompatible with this branchBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.