[Backport 2.x] Separates RegisterModelStep into RegisterLocalModelStep and RegisterRemoteModelStep. Adds GetMLTaskStep. Handles optional params #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…emoteModelStep. Adds GetMLTaskStep. Handles optional params (#155) * added RegisterRemoteModelStep and tests Signed-off-by: Joshua Palis <[email protected]> * Adding RegisterLocalModelStep, fixing tests, adding input/ouput definitions to workflow step json Signed-off-by: Joshua Palis <[email protected]> * Fixing javadoc warnings, fixing log message Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments,making description field optional for RegisterRemoteModelStep and RegisterLocalModelStep Signed-off-by: Joshua Palis <[email protected]> * moving modelConfig builder before adding allConfig Signed-off-by: Joshua Palis <[email protected]> * handling optional description field for remote/local model Signed-off-by: Joshua Palis <[email protected]> * Removing poolingMode, modelMaxLenth, normalizeResult Signed-off-by: Joshua Palis <[email protected]> * adding modelType to required fields check Signed-off-by: Joshua Palis <[email protected]> * Fixing RegisterLocalModelStep to output a task ID instead of a model id Signed-off-by: Joshua Palis <[email protected]> * Adding GetMLTaskStep and tests Signed-off-by: Joshua Palis <[email protected]> * Adding todo for GetMLTask retry capability Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 2142874) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
joshpalis
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2142874 from #155.