-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved UI_METADATA from state to GC index and excluded it from search … #156
Merged
owaiskazi19
merged 1 commit into
opensearch-project:main
from
owaiskazi19:move-metadata
Nov 13, 2023
Merged
Moved UI_METADATA from state to GC index and excluded it from search … #156
owaiskazi19
merged 1 commit into
opensearch-project:main
from
owaiskazi19:move-metadata
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
November 10, 2023 18:06
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
============================================
+ Coverage 68.39% 71.12% +2.73%
- Complexity 339 368 +29
============================================
Files 45 47 +2
Lines 1585 1728 +143
Branches 143 154 +11
============================================
+ Hits 1084 1229 +145
+ Misses 452 443 -9
- Partials 49 56 +7
|
owaiskazi19
force-pushed
the
move-metadata
branch
2 times, most recently
from
November 10, 2023 18:19
72abe3d
to
4cedaad
Compare
joshpalis
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a comment
dbwiddis
approved these changes
Nov 13, 2023
…response Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
move-metadata
branch
from
November 13, 2023 18:37
4cedaad
to
a0edf68
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
#156) Moved UI_METADATA from state to GC index and excluded it from search response Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit cdb8c68) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Nov 13, 2023
…it from search … (#163) Moved UI_METADATA from state to GC index and excluded it from search … (#156) Moved UI_METADATA from state to GC index and excluded it from search response (cherry picked from commit cdb8c68) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Closes #140
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.