-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented throttling for max workflows to be created #151
Conversation
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
6e4576f
to
aa31ec7
Compare
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
src/test/java/org/opensearch/flowframework/transport/CreateWorkflowTransportActionTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/transport/CreateWorkflowTransportActionTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/transport/CreateWorkflowTransportActionTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
src/main/java/org/opensearch/flowframework/common/FlowFrameworkSettings.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
============================================
+ Coverage 67.70% 68.39% +0.68%
- Complexity 330 339 +9
============================================
Files 43 45 +2
Lines 1539 1585 +46
Branches 142 143 +1
============================================
+ Hits 1042 1084 +42
- Misses 448 452 +4
Partials 49 49
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I might quibble on the default max being so high, but OK for now.
(cherry picked from commit 56ccb1d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Implemented throttling for max workflows to be created.
For testing purpose. Set the max limit to 70.
Tried to create workflow again
Verified that no new workflow has been created as the count remains 70
Issues Resolved
Closes #150
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.