[Backport 2.x] Updates exception handling with FlowFrameworkException AND adds dryrun param to Create Workflow #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…n param to Create Workflow (#137) * Simplifying Template format, removing operations, resources created, user outputs Signed-off-by: Joshua Palis <[email protected]> * Initial commit, modifies use case template to seperate workflow inputs into previous_node_inputs and user_inputs, adds graph validation after topologically sorting a workflow into a list of ProcessNode Signed-off-by: Joshua Palis <[email protected]> * Adding tests Signed-off-by: Joshua Palis <[email protected]> * Adding validate graph test Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments, moving sorting/validating prior to executing async, adding success test case for graph validation Signed-off-by: Joshua Palis <[email protected]> * Adding javadocs Signed-off-by: Joshua Palis <[email protected]> * Moving validation prior to updating workflow state to provisioning Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Part 1 Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Part 2 : Moving field names to common value class and using constants Signed-off-by: Joshua Palis <[email protected]> * Adding definition for noop workflow step Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Part 3 Signed-off-by: Joshua Palis <[email protected]> * Modifies rest actions to throw flow framework exceptions, transport actions to create flow framework exceptions Signed-off-by: Joshua Palis <[email protected]> * Fixing credentials field in workflow-step json Signed-off-by: Joshua Palis <[email protected]> * Fixing test Signed-off-by: Joshua Palis <[email protected]> * Using ExceptionsHelper.status() to determine the rest status code based on exceptions thrown by the transport client Signed-off-by: Joshua Palis <[email protected]> * Adding dryrun param to create workflow API, allows for validation before saving Signed-off-by: Joshua Palis <[email protected]> * concatenating log message with exception message on failure Signed-off-by: Joshua Palis <[email protected]> * Adding dry run test Signed-off-by: Joshua Palis <[email protected]> * Simplifying FlowFrameworkException::toXContent Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit c547658) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #144 +/- ##
============================================
- Coverage 69.05% 67.09% -1.97%
- Complexity 302 311 +9
============================================
Files 37 37
Lines 1393 1468 +75
Branches 132 139 +7
============================================
+ Hits 962 985 +23
- Misses 386 434 +48
- Partials 45 49 +4
|
joshpalis
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c547658 from #137.