Put plugin API behind a feature flag #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
============================================
+ Coverage 67.09% 67.58% +0.48%
- Complexity 311 318 +7
============================================
Files 37 38 +1
Lines 1468 1490 +22
Branches 139 140 +1
============================================
+ Hits 985 1007 +22
Misses 434 434
Partials 49 49
|
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
joshpalis
approved these changes
Nov 3, 2023
amitgalitz
approved these changes
Nov 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
* Put plugin API behind a feature flag Signed-off-by: Daniel Widdis <[email protected]> * Add test for feature flag disabled Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit aad17d0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Nov 3, 2023
Put plugin API behind a feature flag (#142) * Put plugin API behind a feature flag * Add test for feature flag disabled --------- (cherry picked from commit aad17d0) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires an OpenSearch cluster setting to be enabled to use REST API.
Follows similar model as AD and ML Commons.
Issues Resolved
Fixes #141
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.