Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tiered caching settings #8592

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Oct 21, 2024

Description

We need to add new settings in tiered caching which were introduced in 2.18. We also corrected few setting name which was wrongly named in older versions.

I will raise a separate PR to fix wrong setting names for older versions 2.14 and above.

Issues Resolved

Closes #8351

Version

2.18

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sagar Upadhyaya <[email protected]>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@sgup432
Copy link
Contributor Author

sgup432 commented Oct 21, 2024

@kolchfa-aws @Naarcha-AWS Can you take a look at this one?

Also I need to correct setting names in the documentation for older versions ie 2.14 upto 2.17. I can separate PR for that, would that work?

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sgup432! Please raise a correction PR against 2.17, and we can backport to all applicable lower versions.

@kolchfa-aws kolchfa-aws merged commit 60be688 into opensearch-project:main Oct 22, 2024
6 checks passed
@kolchfa-aws kolchfa-aws added v2.18.0 release-notes PR: Include this PR in the automated release notes labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add segment setting for tiered cache
2 participants