Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static setting for checkPendingFlushUpdate functionality of lucene index writer #6728

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

CaptainDredge
Copy link
Contributor

@CaptainDredge CaptainDredge commented Mar 20, 2024

Description

Does exactly what PR title says

Issues Resolved

Closes #6705

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress release-notes PR: Include this PR in the automated release notes v2.13.0 labels Mar 20, 2024
@hdhalter hdhalter changed the title Added static setting for checkPendingFlushUpdate functionality of lucene index writer Add static setting for checkPendingFlushUpdate functionality of lucene index writer Mar 20, 2024
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @CaptainDredge! Please provide the default for this setting.

@kolchfa-aws kolchfa-aws self-assigned this Mar 20, 2024
@CaptainDredge
Copy link
Contributor Author

Thank you, @CaptainDredge! Please provide the default for this setting.

Thanks @kolchfa-aws , I've added the default setting

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @CaptainDredge!

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws @CaptainDredge Just a minor deletion. Otherwise, LGTM. Thanks!

@kolchfa-aws kolchfa-aws merged commit 9ef3118 into opensearch-project:main Mar 22, 2024
3 checks passed
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 4 - Doc review PR: Doc review in progress labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add a new setting index.check_pending_flush.enabled to index settings OS doc page
5 participants