Update JWT documentation to recommend only using jwt_header or audit … #5955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logging not both (#5914) * readd auth token doc Signed-off-by: Stephen Crawford <[email protected]> * Fix vale Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Apply suggestions from code review Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Apply suggestions from code review Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Fix embedded command Signed-off-by: Stephen Crawford <[email protected]> * Blank lines after headings Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * change Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Apply suggestions from code review Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Style guidelines Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Signed-off-by: Stephen Crawford <[email protected]> * Apply suggestions from code review Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update _security/access-control/authentication-tokens.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * warn about audit logging of custom headers Signed-off-by: Stephen Crawford <[email protected]> * Update _security/authentication-backends/jwt.md Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 7d8a6a3)
Naarcha-AWS
requested review from
hdhalter,
kolchfa-aws,
vagimeli,
ananzh,
AMoo-Miki and
natebower
as code owners
kolchfa-aws
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…logging not both (#5914)
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Melissa Vagi [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: Naarcha-AWS [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Signed-off-by: Stephen Crawford [email protected]
Co-authored-by: kolchfa-aws [email protected]
Co-authored-by: Melissa Vagi [email protected]
Co-authored-by: Naarcha-AWS [email protected]
(cherry picked from commit 7d8a6a3)
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.