Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for known issue with use of custom codecs on version 2.7.0 #5863

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Dec 12, 2023

Description

Adds known bug related with usage of custom codecs in OpenSearch 2.7.0 for segment replication enabled indices.

Issues Resolved

Fixes #4194

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89
Copy link
Member Author

@hdhalter @Naarcha-AWS : Can you please review this change ?

@Naarcha-AWS Naarcha-AWS added backport 2.7 PR: Backport label for 2.7 backport 2.11 PR: Backport label for 2.11 and removed backport 2.7 PR: Backport label for 2.7 labels Dec 15, 2023
@dreamer-89
Copy link
Member Author

@Naarcha-AWS : As the bug was impacting 2.7.0 only and was fixed in 2.7.1+, I think we don't need backport to 2.11 ?

@dreamer-89
Copy link
Member Author

@Naarcha-AWS @hdhalter : Can you please merge this change

@Naarcha-AWS Naarcha-AWS added backport 2.7 PR: Backport label for 2.7 and removed backport 2.11 PR: Backport label for 2.11 labels Dec 15, 2023
@Naarcha-AWS Naarcha-AWS merged commit f632991 into opensearch-project:2.7 Dec 15, 2023
5 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-5863-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f632991770d0647cf41155d444f8858da9d3320e
# Push it to GitHub
git push --set-upstream origin backport/backport-5863-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-5863-to-2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.7 PR: Backport label for 2.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants