-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding content for the new Notifications plugin #586
Conversation
Signed-off-by: keithhc2 <[email protected]>
Signed-off-by: keithhc2 <[email protected]>
Signed-off-by: keithhc2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work Keith!
i made some small suggestions
LGTM
Signed-off-by: keithhc2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some suggestions for the API descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my suggested changes and let me know if you have any questions. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Keith, i had to modify my comments to be consistent. I'm finished with the review now.
thanks,
Alice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Keith, i needed to update my comment to make it more specific.
Thanks,
Alice
Signed-off-by: keithhc2 <[email protected]>
Signed-off-by: keithhc2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, Alice! I just have a few minor tweak suggestions.
Signed-off-by: keithhc2 <[email protected]>
Signed-off-by: keithhc2 <[email protected]>
@keithhc2 - I'd be happy to sign off on this, but I don't see the option. Do you have to add me? |
@hdhalter If you go to the Files changed tab, you should see a green Review changes button. Click that, and you can comment/approve/request changes/etc. |
Signed-off-by: keithhc2 <[email protected]>
Adds the Notifications plugin
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Site URLs:
../ism/policies.md
https://opensearch.org/docs/latest/im-plugin/ism/policies/
_monitoring-plugins/alerting/monitors.md
https://opensearch.org/docs/latest/monitoring-plugins/alerting/monitors/
(new pages/not yet on site):
_notifications-plugin/api.md
_notifications-plugin/index.md