Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add workflowIds parameter #5779

Merged
merged 13 commits into from
Jan 4, 2024
Merged

[DOC] Add workflowIds parameter #5779

merged 13 commits into from
Jan 4, 2024

Conversation

vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Dec 4, 2023 •
edited by hdhalter
Loading

Description

Adds workflowIds setting

Issues Resolved

Fixes #5421

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli
Add workflowIds parameter
77ab3fb 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli added backport 2.9 PR: Backport label for 2.9 backport 2.10 PR: Backport label for 2.10 backport 2.11 PR: Backport label for 2.11 labels Dec 4, 2023
@vagimeli vagimeli self-assigned this Dec 4, 2023
@vagimeli vagimeli linked an issue Dec 4, 2023 that may be closed by this pull request
[DOC] Add workflowIds parameter to get alerts #5421
Closed
4 tasks
@vagimeli
Copy link
Contributor Author

vagimeli commented Dec 4, 2023

@eirsep Please tech review and approve the parameter setting changes made in this PR. We are closing a content gap. It should be minimal time effort. Thank you :)

@vagimeli vagimeli added the 3 - Tech review PR: Tech review in progress label Dec 4, 2023
@vagimeli
Copy link
Contributor Author

vagimeli commented Dec 8, 2023 •
edited
Loading

Hi @eirsep: Please provide technical review so that we can publish the updated documentation. Thank you.

@vagimeli
Copy link
Contributor Author

@eirsep Please tech review and approve the parameter setting changes made in this PR. We are closing a content gap. It should be minimal time effort. Thank you :)

Hi @eirsep: In order to merge this PR, we need tech review approval. As soon as you approve this content change, I can move forward on merging the PR and publishing the content. Thank you.

@vagimeli vagimeli added the Needs SME Waiting on input from subject matter expert label Dec 15, 2023
@vagimeli
Copy link
Contributor Author

@hdhalter I'm blocked on this PR because I'm not getting a tech review. I've requested a review using the AWS OpenSearch and OpenSearch community Slack channels. No response after a week. Who is the SDM?

@vagimeli vagimeli added Blocked PR: Cannot move forward without assistance and removed Needs SME Waiting on input from subject matter expert labels Dec 21, 2023
@vagimeli
Copy link
Contributor Author

@hdhalter Tech review is only needed for line 1346. I've requested tech review via OpenSearch community Slack channel and AWS OpenSearch Slack channel. No response to date. Who is the SDM?

@hdhalter
Copy link
Contributor

@hdhalter I'm blocked on this PR because I'm not getting a tech review. I've requested a review using the AWS OpenSearch and OpenSearch community Slack channels. No response after a week. Who is the SDM?

I'm checking with @getsaurabh02.

@getsaurabh02
Copy link
Member

Adding @praveensameneni to take a look.

eirsep
eirsep suggested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@eirsep eirsep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested a re-wording for the param description

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress Blocked PR: Cannot move forward without assistance labels Dec 26, 2023
@vagimeli
Update api.md
49ae68e 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Jan 3, 2024
natebower
natebower approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Just one minor change. Otherwise, LGTM!

_observing-your-data/alerting/api.md Outdated Show resolved Hide resolved
@vagimeli @natebower
Update _observing-your-data/alerting/api.md
f316e9c 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli added Quick fix Issues that can be completed fast and removed 5 - Editorial review PR: Editorial review in progress labels Jan 4, 2024
@vagimeli vagimeli merged commit dc41f05 into main Jan 4, 2024
5 checks passed
@vagimeli vagimeli deleted the wokflowID branch January 4, 2024 19:06
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 4, 2024
@github-actions @natebower
[DOC] Add workflowIds parameter (#5779)
a235a4b 
* Add workflowIds parameter

Signed-off-by: Melissa Vagi <[email protected]>

* Copy edit

Signed-off-by: Melissa Vagi <[email protected]>

* Update api.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _observing-your-data/alerting/api.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit dc41f05)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 4, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 4, 2024
@github-actions @natebower
[DOC] Add workflowIds parameter (#5779)
bc2fad4 
* Add workflowIds parameter

Signed-off-by: Melissa Vagi <[email protected]>

* Copy edit

Signed-off-by: Melissa Vagi <[email protected]>

* Update api.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _observing-your-data/alerting/api.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit dc41f05)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 4, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 4, 2024
@github-actions @natebower
[DOC] Add workflowIds parameter (#5779)
47c02f2 
* Add workflowIds parameter

Signed-off-by: Melissa Vagi <[email protected]>

* Copy edit

Signed-off-by: Melissa Vagi <[email protected]>

* Update api.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _observing-your-data/alerting/api.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit dc41f05)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 4, 2024
Merged
vagimeli pushed a commit that referenced this pull request Jan 4, 2024
@opensearch-trigger-bot @github-actions @natebower
[DOC] Add workflowIds parameter (#5779) (#6038)
3a20146 
* Add workflowIds parameter



* Copy edit



* Update api.md



* Update _observing-your-data/alerting/api.md




---------



(cherry picked from commit dc41f05)

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli pushed a commit that referenced this pull request Jan 4, 2024
@opensearch-trigger-bot @github-actions @natebower
[DOC] Add workflowIds parameter (#5779) (#6037)
7392511 
* Add workflowIds parameter



* Copy edit



* Update api.md



* Update _observing-your-data/alerting/api.md




---------



(cherry picked from commit dc41f05)

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli pushed a commit that referenced this pull request Jan 4, 2024
@opensearch-trigger-bot @github-actions @natebower
[DOC] Add workflowIds parameter (#5779) (#6036)
0e5b857 
* Add workflowIds parameter



* Copy edit



* Update api.md



* Update _observing-your-data/alerting/api.md




---------



(cherry picked from commit dc41f05)

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirsep eirsep eirsep requested changes

@natebower natebower natebower approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@ananzh ananzh Awaiting requested review from ananzh

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

Assignees

@vagimeli vagimeli

Labels
backport 2.9 PR: Backport label for 2.9 backport 2.10 PR: Backport label for 2.10 backport 2.11 PR: Backport label for 2.11 Quick fix Issues that can be completed fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Add workflowIds parameter to get alerts
5 participants
@vagimeli @hdhalter @getsaurabh02 @eirsep @natebower