-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster state stats documentation #5662
Conversation
Signed-off-by: Aman Khare <[email protected]>
Signed-off-by: Aman Khare <[email protected]>
@@ -1057,6 +1070,16 @@ published_cluster_states | Object | Statistics for the published cluster states | |||
published_cluster_states.full_states | Integer | The number of published cluster states. | |||
published_cluster_states.incompatible_diffs | Integer | The number of incompatible differences between published cluster states. | |||
published_cluster_states.compatible_diffs | Integer | The number of compatible differences between published cluster states. | |||
cluster_state_stats | Object | Cluster state updates statistics published by active leader. | |||
cluster_state_stats.overall | Object | Cluster state update statistics including local and all remote state uploads done by the node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just say -> Overall cluster state updates statistics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's easy to understand that overall time includes both local state update as well as remote upload. Because currently cluster_state_stats.overall.total_time_in_millis
doesn't signify anything specifically. Is it okay ?
cluster_state_stats.overall.total_time_in_millis | Integer | The total amount of time for all cluster state updates, in milliseconds.
@Naarcha-AWS - what is the status of this? |
@hdhalter: I still need to look over this PR. |
Signed-off-by: Naarcha-AWS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Naarcha-AWS Just a few minor changes. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Description
Cluster state stats were added as part of opensearch-project/OpenSearch#10670 , adding its documentation.
Issues Resolved
Fixes #5400
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.