[DOC]Add new dot expander processor doc #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melissa Vagi <[email protected]>
vagimeli
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
45 tasks
@msfroh Do you have availability to review this PR? I don't want to dump all of the ingest processor reviews on you, so if there are other devs I can tag to share the review load, please let me know. Thank you! |
msfroh
reviewed
Dec 13, 2023
msfroh
reviewed
Dec 13, 2023
Naarcha-AWS
reviewed
Dec 21, 2023
Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
kolchfa-aws
approved these changes
Jan 17, 2024
natebower
reviewed
Jan 18, 2024
| ``` | ||
| {% include copy-curl.html %} | ||
|
|
||
| The response shows that the values were merged into an array: |
There was a problem hiding this comment.
"indicates" instead of "shows"? (optional suggestion)
| } | ||
| ``` | ||
|
|
||
| If there is a field name with a same name but a different path field needs to be renamed. For example, the following simulate call returns a parse exception: |
There was a problem hiding this comment.
"If a field contains the same name but a different path, then the field needs to be renamed"?
| ``` | ||
| {% include copy-curl.html %} | ||
|
|
||
| Now simulate the pipeline: |
There was a problem hiding this comment.
"Now you can simulate the pipeline"?
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
vagimeli
added
5 - Editorial review
natebower
reviewed
Jan 26, 2024
| } | ||
| ``` | ||
|
|
||
| If a field contains the same name but a different path, then the field needs to be renamed. For example, the following simulate call returns a parse exception: |
There was a problem hiding this comment.
Should "simulate" be in code font (my brain wants to incorrectly change it to "simulated")?
Thanks @natebower! I changed to |
Signed-off-by: Melissa Vagi <[email protected]>
vagimeli
added
backport 2.11
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Add new dot expander processor doc Signed-off-by: Melissa Vagi <[email protected]> * Draft content for tech review Signed-off-by: Melissa Vagi <[email protected]> * Address tech review feedback Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Address doc review feedback Signed-off-by: Melissa Vagi <[email protected]> * Edit line 227 Signed-off-by: Melissa Vagi <[email protected]> * Edit line 227 Signed-off-by: Melissa Vagi <[email protected]> * Edit line 227 Signed-off-by: Melissa Vagi <[email protected]> * Address doc review comments Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Added path parameter and field name conflicts sections Signed-off-by: Fanit Kolchina <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/dot-expander.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Address editorial review feedback Signed-off-by: Melissa Vagi <[email protected]> * Update dot-expander.md Signed-off-by: Melissa Vagi <[email protected]> --------- Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 8225f0b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Add new dot expander processor doc * Draft content for tech review * Address tech review feedback * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Address doc review feedback * Edit line 227 * Edit line 227 * Edit line 227 * Address doc review comments * Update _ingest-pipelines/processors/dot-expander.md * Added path parameter and field name conflicts sections * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Update _ingest-pipelines/processors/dot-expander.md * Address editorial review feedback * Update dot-expander.md --------- (cherry picked from commit 8225f0b) Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new dot expander processor documentation to address content gap
Issues Resolved
#4647
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.