Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix AD-Visualizations integration feature documentation #5562

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

ohltyler
Copy link
Member

Description

Describe what this change achieves.
There is incorrect documentation regarding the AD-Visualization integration feature. Specifically:

  • has incorrect and vague description of what visualization types are eligible for the feature
  • has incorrect references to alerting in 2 places

I've updated the AD doc page to include these fixes. The eligibility information is replicated from the Alerting-Visualization integration feature docs which has the correct and detailed description.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler added backport 2.9 PR: Backport label for 2.9 backport 2.10 PR: Backport label for 2.10 backport 2.11 PR: Backport label for 2.11 labels Nov 10, 2023
@ohltyler ohltyler changed the title Fix AD-Visualizations integration feature documentation [DOC] Fix AD-Visualizations integration feature documentation Nov 10, 2023
@ohltyler
Copy link
Member Author

This change should be backported up to and including 2.9. Let me know if there is anything else needed to propagate the changes after this PR and its backports are merged.

Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on behalf of doc review and editorial review. LGTM!

@vagimeli vagimeli merged commit 5ae73a1 into opensearch-project:main Nov 10, 2023
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 10, 2023
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 5ae73a1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 10, 2023
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 5ae73a1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 10, 2023
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 5ae73a1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Nov 10, 2023
(cherry picked from commit 5ae73a1)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Nov 10, 2023
(cherry picked from commit 5ae73a1)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Nov 10, 2023
(cherry picked from commit 5ae73a1)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ohltyler ohltyler deleted the fix-ad-vis-docs branch November 10, 2023 19:29
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly-detection backport 2.9 PR: Backport label for 2.9 backport 2.10 PR: Backport label for 2.10 backport 2.11 PR: Backport label for 2.11 dashboards Usability visualizations xx-documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants