-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Fix AD-Visualizations integration feature documentation #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
November 10, 2023 18:51
ohltyler
added
backport 2.9
PR: Backport label for 2.9
backport 2.10
PR: Backport label for 2.10
backport 2.11
PR: Backport label for 2.11
labels
Nov 10, 2023
ohltyler
changed the title
Fix AD-Visualizations integration feature documentation
[DOC] Fix AD-Visualizations integration feature documentation
Nov 10, 2023
ohltyler
added
xx-documentation
Improvements or additions to documentation
dashboards
Usability
visualizations
anomaly-detection
labels
Nov 10, 2023
This change should be backported up to and including 2.9. Let me know if there is anything else needed to propagate the changes after this PR and its backports are merged. |
vagimeli
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed on behalf of doc review and editorial review. LGTM!
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 5ae73a1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 5ae73a1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 5ae73a1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
Nov 10, 2023
(cherry picked from commit 5ae73a1) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Nov 10, 2023
(cherry picked from commit 5ae73a1) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Nov 10, 2023
(cherry picked from commit 5ae73a1) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
Signed-off-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
anomaly-detection
backport 2.9
PR: Backport label for 2.9
backport 2.10
PR: Backport label for 2.10
backport 2.11
PR: Backport label for 2.11
dashboards
Usability
visualizations
xx-documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
There is incorrect documentation regarding the AD-Visualization integration feature. Specifically:
I've updated the AD doc page to include these fixes. The eligibility information is replicated from the Alerting-Visualization integration feature docs which has the correct and detailed description.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.