Adjust Logstash example query quotes #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change double quote to single quote on query Signed-off-by: Zachary Wilkins <[email protected]>
znwilkins
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
|
@znwilkins: Is it only the Query setting that requires |
|
@Naarcha-AWS yes that's correct. The other settings do not contain double quotes within the string so are not affected. I also tried escaping the double quotes for |
Naarcha-AWS
approved these changes
Nov 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Change double quote to single quote on query Signed-off-by: Zachary Wilkins <[email protected]> (cherry picked from commit 77bcd03) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
pushed a commit
that referenced
this pull request
Nov 8, 2023
Change double quote to single quote on query (cherry picked from commit 77bcd03) Signed-off-by: Zachary Wilkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
Change double quote to single quote on query Signed-off-by: Zachary Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The example for reading from Opensearch using Logstash specifies double quotes around a query containing double quotes. This causes the Ruby parser to complain with an error of the form:
Swapping to single quotes resolves the issue. If this PR is accepted, an identical change should also be made to the plugin README (I'm happy to open another PR).
Thanks!
Issues Resolved
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.