Add custom pre and post processor functions #5300
Merged
+113
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
requested review from
hdhalter,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
ylwu-amzn
reviewed
Nov 3, 2023
| | `huggingface/sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2` | 384-dimensional dense vector space. | Yes | - [model_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2/1.0.1/torch_script/sentence-transformers_paraphrase-multilingual-MiniLM-L12-v2-1.0.1-torch_script.zip)<br>- [config_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2/1.0.1/torch_script/config.json) | - [model_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2/1.0.1/onnx/sentence-transformers_paraphrase-multilingual-MiniLM-L12-v2-1.0.1-onnx.zip)<br>- [config_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2/1.0.1/onnx/config.json) | | ||
| | `huggingface/sentence-transformers/paraphrase-mpnet-base-v2` | 768-dimensional dense vector space. | Yes | - [model_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/paraphrase-mpnet-base-v2/1.0.0/torch_script/sentence-transformers_paraphrase-mpnet-base-v2-1.0.0-torch_script.zip)<br>- [config_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/paraphrase-mpnet-base-v2/1.0.0/torch_script/config.json) | - [model_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/paraphrase-mpnet-base-v2/1.0.0/onnx/sentence-transformers_paraphrase-mpnet-base-v2-1.0.0-onnx.zip)<br>- [config_url](https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/paraphrase-mpnet-base-v2/1.0.0/onnx/config.json) | |
There was a problem hiding this comment.
This model version is 1.0.0, which is different with other models. Suggest add a new version column to show the model version
There was a problem hiding this comment.
@kolchfa-aws Could you please add these models too mentioned in this issue: opensearch-project/opensearch-py-ml#334?
There was a problem hiding this comment.
@dhrubo-os We've added the first 3 already (see this section). For the other two, could you provide the dimensionality and autotruncation so I can fill the table? Thanks!
There was a problem hiding this comment.
@kolchfa-aws distiluse-base-multilingual-cased-v1 --> 512
paraphrase-mpnet-base-v2 --> 768
Auto truncation is yes for both of them.
ylwu-amzn
reviewed
Nov 3, 2023
| "name": "YOUR CONNECTOR NAME", | ||
| "description": "YOUR CONNECTOR DESCRIPTION", | ||
| "version": "YOUR CONNECTOR VERSION", | ||
| "name": "<YOUR CONNECTOR NAME>", |
There was a problem hiding this comment.
Suggest add pre/post process functions https://github.com/opensearch-project/ml-commons/blob/main/docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md
ylwu-amzn
reviewed
Nov 3, 2023
Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
|
@ylwu-amzn I implemented the changes. Please review again to make sure everything looks good. Thanks! |
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
vagimeli
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
@kolchfa-aws Great writing to add, correct, and clarify information!
dhrubo-os
approved these changes
Nov 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Add custom pre and post processor functions Signed-off-by: Fanit Kolchina <[email protected]> * Uniform placeholder format Signed-off-by: Fanit Kolchina <[email protected]> * Add custom pre and post processor blueprint Signed-off-by: Fanit Kolchina <[email protected]> * Add a pretrained model Signed-off-by: Fanit Kolchina <[email protected]> * Update _ml-commons-plugin/extensibility/blueprints.md Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Implemented tech review comments Signed-off-by: Fanit Kolchina <[email protected]> * Add two more models Signed-off-by: Fanit Kolchina <[email protected]> * Specify json code highlighter Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Yaliang Wu <[email protected]> (cherry picked from commit 3dbcc34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Add custom pre and post processor functions * Uniform placeholder format * Add custom pre and post processor blueprint * Add a pretrained model * Update _ml-commons-plugin/extensibility/blueprints.md * Implemented tech review comments * Add two more models * Specify json code highlighter --------- (cherry picked from commit 3dbcc34) Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yaliang Wu <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Add custom pre and post processor functions Signed-off-by: Fanit Kolchina <[email protected]> * Uniform placeholder format Signed-off-by: Fanit Kolchina <[email protected]> * Add custom pre and post processor blueprint Signed-off-by: Fanit Kolchina <[email protected]> * Add a pretrained model Signed-off-by: Fanit Kolchina <[email protected]> * Update _ml-commons-plugin/extensibility/blueprints.md Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Implemented tech review comments Signed-off-by: Fanit Kolchina <[email protected]> * Add two more models Signed-off-by: Fanit Kolchina <[email protected]> * Specify json code highlighter Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom pre and post processor functions and a Bedrock connector documentation
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.