Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Change navigation for better usability #5227

Merged
merged 9 commits into from
Oct 17, 2023
Merged

[DOC] Change navigation for better usability #5227

merged 9 commits into from
Oct 17, 2023

Conversation

vagimeli
Copy link
Contributor

Description

Changes navigation menu for better usability

Issues Resolved

NA

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Copy link
Contributor Author

vagimeli commented Oct 17, 2023

@kolchfa-aws Please review these navigation changes. I moved the Ingest Pipelines to the main menu and moved DQL to a main level under Dashboards. Thank you :)

Screenshot 2023-10-17 at 11 51 20 AM Screenshot 2023-10-17 at 11 40 17 AM

@vagimeli vagimeli self-assigned this Oct 17, 2023
@vagimeli vagimeli added the backport 2.11 PR: Backport label for 2.11 label Oct 17, 2023
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When adding a new collection, set the parent page nav_exclude to true and don't list the parent page in the parent of children pages.

@vagimeli
Copy link
Contributor Author

When adding a new collection, set the parent page nav_exclude to true and don't list the parent page in the parent of children pages

@kolchfa-aws Thank you. I've noted for future reference :)

@vagimeli vagimeli merged commit 27798ba into main Oct 17, 2023
4 checks passed
@vagimeli vagimeli deleted the fix-navigation branch October 17, 2023 21:22
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 17, 2023
* Change navigation for better usability

* Remove duplicate parent page and fix navigation for new pages

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 27798ba)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Oct 17, 2023
* Change navigation for better usability

* Remove duplicate parent page and fix navigation for new pages



---------




(cherry picked from commit 27798ba)

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Fanit Kolchina <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
* Change navigation for better usability

* Remove duplicate parent page and fix navigation for new pages

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
vagimeli added a commit that referenced this pull request Dec 21, 2023
* Change navigation for better usability

* Remove duplicate parent page and fix navigation for new pages

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.11 PR: Backport label for 2.11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants