Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSB Documentation] Remove generate documentation and update SigV4 documentation for OSB #5174

Merged

Conversation

IanHoang
Copy link
Contributor

@IanHoang IanHoang commented Oct 6, 2023

Description

Removes generate subcommand as this is not supported anymore. Also, removes extra character from example of SigV4 input in SigV4 documentation.

Issues Resolved

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS
Copy link
Collaborator

@IanHoang: There's a link to the [generate] command on this page: https://opensearch.org/docs/latest/benchmark/commands/index/.

We need to remove it before we can merge this in.

@IanHoang
Copy link
Contributor Author

@IanHoang: There's a link to the [generate] command on this page: https://opensearch.org/docs/latest/benchmark/commands/index/.

We need to remove it before we can merge this in.

Removed the link to generate page. Thanks for the heads up!

@Naarcha-AWS Naarcha-AWS merged commit 6f196de into opensearch-project:main Oct 10, 2023
3 checks passed
@Naarcha-AWS Naarcha-AWS added the backport 2.10 PR: Backport label for 2.10 label Oct 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2023
…cumentation for OSB (#5174)

* Remove generate documentation and update SigV4 documentation for OSB

Signed-off-by: Ian Hoang <[email protected]>

* Remove generate link reference in index page

Signed-off-by: Ian Hoang <[email protected]>

---------

Signed-off-by: Ian Hoang <[email protected]>
Co-authored-by: Ian Hoang <[email protected]>
(cherry picked from commit 6f196de)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS pushed a commit that referenced this pull request Oct 10, 2023
…cumentation for OSB (#5174) (#5178)

* Remove generate documentation and update SigV4 documentation for OSB



* Remove generate link reference in index page



---------



(cherry picked from commit 6f196de)

Signed-off-by: Ian Hoang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ian Hoang <[email protected]>
vagimeli pushed a commit that referenced this pull request Oct 13, 2023
…cumentation for OSB (#5174)

* Remove generate documentation and update SigV4 documentation for OSB

Signed-off-by: Ian Hoang <[email protected]>

* Remove generate link reference in index page

Signed-off-by: Ian Hoang <[email protected]>

---------

Signed-off-by: Ian Hoang <[email protected]>
Co-authored-by: Ian Hoang <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
…cumentation for OSB (opensearch-project#5174)

* Remove generate documentation and update SigV4 documentation for OSB

Signed-off-by: Ian Hoang <[email protected]>

* Remove generate link reference in index page

Signed-off-by: Ian Hoang <[email protected]>

---------

Signed-off-by: Ian Hoang <[email protected]>
Co-authored-by: Ian Hoang <[email protected]>
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
…cumentation for OSB (#5174)

* Remove generate documentation and update SigV4 documentation for OSB

Signed-off-by: Ian Hoang <[email protected]>

* Remove generate link reference in index page

Signed-off-by: Ian Hoang <[email protected]>

---------

Signed-off-by: Ian Hoang <[email protected]>
Co-authored-by: Ian Hoang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.10 PR: Backport label for 2.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants