Add total wait time to thread pool in nodes stats #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
requested review from
cwillum,
hdhalter,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
kolchfa-aws
added
release-notes
jed326
reviewed
Oct 3, 2023
| @@ -977,6 +979,7 @@ active | Integer | The number of active threads in the pool. | |||
| rejected | Integer | The number of tasks that have been rejected. | |||
| largest | Integer | The peak number of threads in the pool. | |||
| completed | Integer | The number of tasks completed. | |||
| total_wait_time | Integer | The total time tasks spent waiting in the thread pool queue. | |||
There was a problem hiding this comment.
Not all thread_pools support this metric today -- only search, search_throttled, and index_searcher thread_pools support it. Not sure what the right place to mention this (if at all) is
jed326
approved these changes
Oct 3, 2023
kolchfa-aws
commented
Oct 3, 2023
Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
commented
Oct 3, 2023
Signed-off-by: kolchfa-aws <[email protected]>
hdhalter
approved these changes
Oct 3, 2023
Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
natebower
reviewed
Oct 3, 2023
| @@ -1066,7 +1069,7 @@ total.count | Integer | The total number of documents ingested by the node. | |||
| total.time_in_millis | Integer | The total amount of time for preprocessing ingest documents, in milliseconds. | |||
| total.current | Integer | The total number of documents that are currently being ingested by the node. | |||
| total.failed | Integer | The total number of failed ingestions for the node. | |||
| pipelines | Object | Ingest pipeline statistics for the node. Each pipeline is a nested object specified by its ID with the properties listed below. | |||
| pipelines | Object | Ingest pipeline statistics for the node. Each pipeline is a nested object specified by its ID with the following properties. | |||
There was a problem hiding this comment.
Should "with" be "and has", as on line 1108?
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
commented
Oct 3, 2023
Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
added
6 - Done but waiting to merge
sohami
reviewed
Oct 10, 2023
| @@ -977,6 +979,7 @@ active | Integer | The number of active threads in the pool. | |||
| rejected | Integer | The number of tasks that have been rejected. | |||
| largest | Integer | The peak number of threads in the pool. | |||
| completed | Integer | The number of tasks completed. | |||
| total_wait_time | Integer | The total amount of time tasks spent waiting in the thread pool queue. Currently, only `search`, `search_throttled`, and `index_searcher` thread pools support this metric. | |||
There was a problem hiding this comment.
@kolchfa-aws @jed326 We are saying that this is supported for search threadpool but in the example above it is showing up for ad-batch-task-threadpool and OPENSEARCH_ML_TASK_THREAD_POOL. So either we add search threadpool stats in above example with this new metric or remove the new metric from those threadpool
Signed-off-by: Fanit Kolchina <[email protected]>
sohami
approved these changes
Oct 10, 2023
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
…#5120) * Add total wait time to thread pool in nodes stats Signed-off-by: Fanit Kolchina <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Signed-off-by: kolchfa-aws <[email protected]> * Removed total wait time from response Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Add total wait time to thread pool in nodes stats Signed-off-by: Fanit Kolchina <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Update _api-reference/nodes-apis/nodes-stats.md Signed-off-by: kolchfa-aws <[email protected]> * Removed total wait time from response Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5007
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.