-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update segment replication to include alerting plugin limitation #4976
Conversation
Signed-off-by: Melissa Vagi <[email protected]>
@dreamer-89 Please provide your technical review of the updated text in lines 25-27. Thank you, Melissa cc: @Naarcha-AWS |
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Melissa Vagi <[email protected]>
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
…mments Signed-off-by: Melissa Vagi <[email protected]>
…mments Signed-off-by: Melissa Vagi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments and please fix links. Thanks!
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
…tion/index.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vagimeli Please see my comments and changes and let me know if you have any questions. Thanks!
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
## Use cases | ||
|
||
Segment replication can be applied in a variety of scenarios, including: | ||
|
||
- Users who have high write loads but do not have high search requirements and are comfortable with longer refresh times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Users" are not "scenarios", so the first two items do not complete the stem. The stem is fine, but I would rephrase the first two items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised.
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
@@ -106,11 +100,13 @@ When using segment replication, consider the following: | |||
|
|||
1. Enabling segment replication for an existing index requires [reindexing](https://github.com/opensearch-project/OpenSearch/issues/3685). | |||
1. [Cross-cluster replication](https://github.com/opensearch-project/OpenSearch/issues/4090) does not currently use segment replication to copy between clusters. | |||
1. Segment replication is not compatible with [document-level monitors]({{site.url}}{{site.baseurl}}/observing-your-data/alerting/api/#document-level-monitors), which are used with the [Alerting]({{site.url}}{{site.baseurl}}/install-and-configure/plugins/) plugin. The Alerting plugin uses the latest available data on replica shards when using the `immediate` refresh policy, and segment replication can delay the policy's availability, resulting in stale replica shards. | |||
1. Segment replication is not compatible with [security analytics]({{site.url}}{{site.baseurl}}/security-analytics/index/). Security analytics uses document-level monitors, which are not compatible with segment replication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should both instances of "Security Analytics" be capitalized as a proper noun?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as we're referring to the Security Analytics plugin.
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
_tuning-your-cluster/availability-and-recovery/segment-replication/index.md
Outdated
Show resolved
Hide resolved
…tion/index.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
…tion/index.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
…tion/index.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
…tion/index.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@natebower Please review the changes made to address comments in lines 27-28 and 103-104. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Melissa Vagi <[email protected]>
#4976) * Update documentation to include alerting and secutiry analytics plugin limitations --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
opensearch-project#4976) * Update documentation to include alerting and secutiry analytics plugin limitations --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
#4976) * Update documentation to include alerting and secutiry analytics plugin limitations --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Description
Update segment replication to include alerting plugin limitation
Issues Resolved
#4967
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.