Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update segment replication to include alerting plugin limitation #4976

Merged
merged 17 commits into from
Sep 13, 2023

Conversation

vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Sep 6, 2023

Description

Update segment replication to include alerting plugin limitation

Issues Resolved

#4967

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli
Copy link
Contributor Author

vagimeli commented Sep 6, 2023

@dreamer-89 Please provide your technical review of the updated text in lines 25-27. Thank you, Melissa

cc: @Naarcha-AWS

@vagimeli vagimeli linked an issue Sep 6, 2023 that may be closed by this pull request
4 tasks
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments and please fix links. Thanks!

…tion/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Sep 11, 2023
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Sep 12, 2023
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Please see my comments and changes and let me know if you have any questions. Thanks!

## Use cases

Segment replication can be applied in a variety of scenarios, including:

- Users who have high write loads but do not have high search requirements and are comfortable with longer refresh times.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Users" are not "scenarios", so the first two items do not complete the stem. The stem is fine, but I would rephrase the first two items.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised.

@@ -106,11 +100,13 @@ When using segment replication, consider the following:

1. Enabling segment replication for an existing index requires [reindexing](https://github.com/opensearch-project/OpenSearch/issues/3685).
1. [Cross-cluster replication](https://github.com/opensearch-project/OpenSearch/issues/4090) does not currently use segment replication to copy between clusters.
1. Segment replication is not compatible with [document-level monitors]({{site.url}}{{site.baseurl}}/observing-your-data/alerting/api/#document-level-monitors), which are used with the [Alerting]({{site.url}}{{site.baseurl}}/install-and-configure/plugins/) plugin. The Alerting plugin uses the latest available data on replica shards when using the `immediate` refresh policy, and segment replication can delay the policy's availability, resulting in stale replica shards.
1. Segment replication is not compatible with [security analytics]({{site.url}}{{site.baseurl}}/security-analytics/index/). Security analytics uses document-level monitors, which are not compatible with segment replication.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should both instances of "Security Analytics" be capitalized as a proper noun?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as we're referring to the Security Analytics plugin.

vagimeli and others added 5 commits September 13, 2023 09:23
…tion/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
…tion/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
…tion/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
…tion/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Copy link
Contributor Author

@natebower Please review the changes made to address comments in lines 27-28 and 103-104. Thanks!

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli merged commit 60ee1fa into main Sep 13, 2023
@vagimeli vagimeli deleted the segment-4967 branch September 13, 2023 15:53
vagimeli added a commit that referenced this pull request Sep 19, 2023
#4976)

* Update documentation to include alerting and secutiry analytics plugin limitations
---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
opensearch-project#4976)

* Update documentation to include alerting and secutiry analytics plugin limitations
---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli added a commit that referenced this pull request Dec 21, 2023
#4976)

* Update documentation to include alerting and secutiry analytics plugin limitations
---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Alerting plugin not compatible with segment replication feature
7 participants