-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new table to list and describe supported log types for detector creation #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cwillum <[email protected]>
cwillum
added
2 - In progress
Issue/PR: The issue or PR is in progress.
security-analytics
backport 2.9
PR: Backport label for 2.9
labels
Aug 30, 2023
cwillum
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
August 30, 2023 23:25
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
cwillum
added
3 - Tech review
PR: Tech review in progress
and removed
2 - In progress
Issue/PR: The issue or PR is in progress.
labels
Sep 6, 2023
Contacted Security Analytics team members for tech review and additional input on descriptions of log types. |
amsiglan
approved these changes
Sep 8, 2023
cwillum
added
4 - Doc review
PR: Doc review in progress
and removed
3 - Tech review
PR: Tech review in progress
labels
Sep 12, 2023
@amsiglan Big thanks. |
hdhalter
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits. Looks good!
Signed-off-by: cwillum <[email protected]>
cwillum
added
backport 2.10
PR: Backport label for 2.10
3 - Done
Issue is done/complete
and removed
4 - Doc review
PR: Doc review in progress
labels
Sep 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
… creation (#4946) * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> --------- Signed-off-by: cwillum <[email protected]> (cherry picked from commit 8ee9554) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwillum
pushed a commit
that referenced
this pull request
Sep 26, 2023
… creation (#4946) (#5110) * fix#4945 add log types table * fix#4945 add log types table * fix#4945 add log types table * fix#4945 add log types table * fix#4945 add log types table * fix#4945 add log types table * fix#4945 add log types table * fix#4945 add log types table --------- (cherry picked from commit 8ee9554) Signed-off-by: cwillum <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
Oct 13, 2023
… creation (#4946) * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
… creation (opensearch-project#4946) * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> --------- Signed-off-by: cwillum <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
… creation (#4946) * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> * fix#4945 add log types table Signed-off-by: cwillum <[email protected]> --------- Signed-off-by: cwillum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new topic that lists supported log types.
Issues Resolved
Fixes #4945
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.