Document OpenSearch 2.0 Java compatibility. #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <[email protected]>
Naarcha-AWS
reviewed
Mar 31, 2022
Signed-off-by: dblock <[email protected]>
dlvenable
reviewed
Apr 6, 2022
| 1.0 - 1.2.x | 11, 15 | 15.0.1+9 | ||
| 1.3.x | 8, 11, 14 | 11.0.14.1+1 | ||
| 2.0.0 | 11, 17 | 17.0.2+8 |
There was a problem hiding this comment.
Should the documentation specify the exact Java version (e.g. 17.0.2+8) for each bundle? You would need to update this for each build, or the value grows stale. The documentation above clearly outlines how to find the specific Java version for any bundle - that seems sufficient for anybody who needs the full version number.
You could just have 17 here for 2.0.0.
There was a problem hiding this comment.
The exact version bundled is the third column called "Bundled Java Version".
2.0.0 has 17 in the "Compatible Java Versions"
What am I missing?
|
@dlvenable Can we get this merged? |
dlvenable
approved these changes
May 17, 2022
Naarcha-AWS
requested changes
May 26, 2022
Commit quick edit.
|
@dblock: I'm going to take over this PR to ensure gets merged in for 2.0.0 |
|
Closing in favor of #609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock [email protected]
Description
Took a stab at cleaning up the compatibility page and documenting 2.0 as part of opensearch-project/opensearch-plugins#132.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.