Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FORMATTING_GUIDE.md with link to code samples in style guide #4709

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

hdhalter
Copy link
Contributor

@hdhalter hdhalter commented Aug 7, 2023

Added link to style guide.

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Added link to style guide.

Signed-off-by: Heather Halter <[email protected]>
@hdhalter hdhalter self-assigned this Aug 7, 2023
@hdhalter hdhalter added the 4 - Doc review PR: Doc review in progress label Aug 7, 2023
FORMATTING_GUIDE.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdhalter hdhalter merged commit aed1d68 into main Aug 7, 2023
akashsha1 pushed a commit to akashsha1/documentation-website that referenced this pull request Aug 7, 2023
…pensearch-project#4709)

* Update FORMATTING_GUIDE.md

Added link to style guide.

Signed-off-by: Heather Halter <[email protected]>

* Update FORMATTING_GUIDE.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Shankaran <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
…pensearch-project#4709)

* Update FORMATTING_GUIDE.md

Added link to style guide.

Signed-off-by: Heather Halter <[email protected]>

* Update FORMATTING_GUIDE.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
…4709)

* Update FORMATTING_GUIDE.md

Added link to style guide.

Signed-off-by: Heather Halter <[email protected]>

* Update FORMATTING_GUIDE.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
@hdhalter hdhalter deleted the hdhalter-patch-2 branch March 28, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants