Add ML connector edits #4636

Naarcha-AWS · 2023-07-25T20:34:58Z

Adds information about integrator.
Separates integrator settings from connection settings.
Adds links to blueprints.
Addresses additional technical feedback.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naarcha-AWS <[email protected]>

_ml-commons-plugin/connectors.md

Signed-off-by: Naarcha-AWS <[email protected]>

_ml-commons-plugin/connectors.md

Signed-off-by: Naarcha-AWS <[email protected]>

_ml-commons-plugin/extensibility/blueprints.md

_ml-commons-plugin/extensibility/connectors.md

_ml-commons-plugin/extensibility/blueprints.md

_ml-commons-plugin/extensibility/index.md

Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

hdhalter

I can't speak to the content from a technical standpoint, but here are a few wording suggestions.

_ml-commons-plugin/extensibility/blueprints.md

_ml-commons-plugin/extensibility/connectors.md

Co-authored-by: Heather Halter <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

Signed-off-by: Naarcha-AWS <[email protected]>

natebower

@Naarcha-AWS Nice job :-) Let me know if you have any questions. Thanks!

_ml-commons-plugin/extensibility/blueprints.md

_ml-commons-plugin/extensibility/index.md

natebower · 2023-08-10T17:45:50Z

_ml-commons-plugin/extensibility/index.md

+
+### Node settings
+
+Remote models based on external connectors consume less resources. Therefore, you can deploy any model from a standalone connector using data nodes. To make sure that your standalone connection uses data nodes, set `plugins.ml_commons.only_run_on_ml_node` to `false`, as shown in the following example:


Use "fewer" if the noun is countable and "less" if it isn't. Fewer cars, less traffic.

_ml-commons-plugin/extensibility/index.md

Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

_ml-commons-plugin/extensibility/index.md

Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

natebower

LGTM

Signed-off-by: Naarcha-AWS <[email protected]>

* Add ML connector edits Signed-off-by: Naarcha-AWS <[email protected]> * Change integrators to blueprints Signed-off-by: Naarcha-AWS <[email protected]> * Add PM feedback Signed-off-by: Naarcha-AWS <[email protected]> * Change connector names Signed-off-by: Naarcha-AWS <[email protected]> * Add note about which parameters are relevant to admins. Signed-off-by: Naarcha-AWS <[email protected]> * Make seperation between personas more clear Signed-off-by: Naarcha-AWS <[email protected]> * Fix typo Signed-off-by: Naarcha-AWS <[email protected]> * Add technical feedback Signed-off-by: Naarcha-AWS <[email protected]> * Breakout connectors and blueprints into two pages. Signed-off-by: Naarcha-AWS <[email protected]> * Fix blueprint links Signed-off-by: Naarcha-AWS <[email protected]> * Address additional technical feedback Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Add Doc review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Yaliang Wu <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 62ab741) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add ML connector edits * Change integrators to blueprints * Add PM feedback * Change connector names * Add note about which parameters are relevant to admins. * Make seperation between personas more clear * Fix typo * Add technical feedback * Breakout connectors and blueprints into two pages. * Fix blueprint links * Address additional technical feedback * Apply suggestions from code review * Apply suggestions from code review * Add Doc review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review --------- (cherry picked from commit 62ab741) Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yaliang Wu <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]>

* Add ML connector edits Signed-off-by: Naarcha-AWS <[email protected]> * Change integrators to blueprints Signed-off-by: Naarcha-AWS <[email protected]> * Add PM feedback Signed-off-by: Naarcha-AWS <[email protected]> * Change connector names Signed-off-by: Naarcha-AWS <[email protected]> * Add note about which parameters are relevant to admins. Signed-off-by: Naarcha-AWS <[email protected]> * Make seperation between personas more clear Signed-off-by: Naarcha-AWS <[email protected]> * Fix typo Signed-off-by: Naarcha-AWS <[email protected]> * Add technical feedback Signed-off-by: Naarcha-AWS <[email protected]> * Breakout connectors and blueprints into two pages. Signed-off-by: Naarcha-AWS <[email protected]> * Fix blueprint links Signed-off-by: Naarcha-AWS <[email protected]> * Address additional technical feedback Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Add Doc review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Yaliang Wu <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nathan Bower <[email protected]>

Add ML connector edits

ec6f904

Signed-off-by: Naarcha-AWS <[email protected]>

Naarcha-AWS requested review from cwillum, hdhalter, kolchfa-aws, vagimeli, ananzh, seanneumann, AMoo-Miki and natebower as code owners July 25, 2023 20:34

Naarcha-AWS added 3 - Tech review PR: Tech review in progress v2.9.0 labels Jul 25, 2023

ylwu-amzn reviewed Jul 25, 2023

View reviewed changes

_ml-commons-plugin/connectors.md Outdated Show resolved Hide resolved

ylwu-amzn reviewed Jul 25, 2023

View reviewed changes

_ml-commons-plugin/connectors.md Outdated Show resolved Hide resolved

ylwu-amzn reviewed Jul 25, 2023

View reviewed changes

_ml-commons-plugin/connectors.md Outdated Show resolved Hide resolved

ylwu-amzn reviewed Jul 25, 2023

View reviewed changes

_ml-commons-plugin/connectors.md Outdated Show resolved Hide resolved

Naarcha-AWS and others added 7 commits July 26, 2023 12:18

Change integrators to blueprints

eefad7e

Signed-off-by: Naarcha-AWS <[email protected]>

Add PM feedback

c6eb90a

Signed-off-by: Naarcha-AWS <[email protected]>

Change connector names

30728d3

Signed-off-by: Naarcha-AWS <[email protected]>

Add note about which parameters are relevant to admins.

2401e46

Signed-off-by: Naarcha-AWS <[email protected]>

Make seperation between personas more clear

d51d67a

Signed-off-by: Naarcha-AWS <[email protected]>

Merge branch 'main' into last-minute-ml-updates

11e0ab3

Fix typo

2c8cc48

Signed-off-by: Naarcha-AWS <[email protected]>

ylwu-amzn reviewed Aug 3, 2023

View reviewed changes

_ml-commons-plugin/connectors.md Outdated Show resolved Hide resolved

ylwu-amzn reviewed Aug 3, 2023

View reviewed changes

_ml-commons-plugin/connectors.md Outdated Show resolved Hide resolved

ylwu-amzn reviewed Aug 3, 2023

View reviewed changes

_ml-commons-plugin/connectors.md Outdated Show resolved Hide resolved

Zhangxunmt reviewed Aug 3, 2023

View reviewed changes

Naarcha-AWS and others added 4 commits August 7, 2023 11:42

Merge branch 'main' into last-minute-ml-updates

98d9307

Merge branch 'main' into last-minute-ml-updates

e99475f

Add technical feedback

456234d

Signed-off-by: Naarcha-AWS <[email protected]>

Breakout connectors and blueprints into two pages.

8804545

Signed-off-by: Naarcha-AWS <[email protected]>

ylwu-amzn reviewed Aug 8, 2023

View reviewed changes

_ml-commons-plugin/extensibility/blueprints.md Outdated Show resolved Hide resolved

ylwu-amzn reviewed Aug 8, 2023

View reviewed changes

_ml-commons-plugin/extensibility/blueprints.md Outdated Show resolved Hide resolved

ylwu-amzn reviewed Aug 8, 2023

View reviewed changes

_ml-commons-plugin/extensibility/blueprints.md Outdated Show resolved Hide resolved

ylwu-amzn reviewed Aug 8, 2023

View reviewed changes

_ml-commons-plugin/extensibility/connectors.md Outdated Show resolved Hide resolved

ylwu-amzn reviewed Aug 9, 2023

View reviewed changes

_ml-commons-plugin/extensibility/blueprints.md Outdated Show resolved Hide resolved

Naarcha-AWS commented Aug 9, 2023

View reviewed changes

_ml-commons-plugin/extensibility/index.md Outdated Show resolved Hide resolved

Apply suggestions from code review

9e7e46f

Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

Naarcha-AWS added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Aug 10, 2023

hdhalter reviewed Aug 10, 2023

View reviewed changes

Naarcha-AWS and others added 3 commits August 10, 2023 12:00

Merge branch 'main' into last-minute-ml-updates

5f5d89b

Apply suggestions from code review

de010d3

Co-authored-by: Heather Halter <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

Add Doc review

0d0ff91

Signed-off-by: Naarcha-AWS <[email protected]>

natebower reviewed Aug 10, 2023

View reviewed changes

Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Aug 10, 2023

Apply suggestions from code review

3be4607

Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

Naarcha-AWS commented Aug 10, 2023

View reviewed changes

_ml-commons-plugin/extensibility/index.md Outdated Show resolved Hide resolved

Naarcha-AWS commented Aug 10, 2023

View reviewed changes

_ml-commons-plugin/extensibility/index.md Outdated Show resolved Hide resolved

Apply suggestions from code review

52c6cf3

Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

natebower approved these changes Aug 10, 2023

View reviewed changes

Apply suggestions from code review

1aee65a

Signed-off-by: Naarcha-AWS <[email protected]>

Naarcha-AWS merged commit 62ab741 into main Aug 10, 2023

Naarcha-AWS deleted the last-minute-ml-updates branch August 10, 2023 19:55

Naarcha-AWS added the backport 2.9 PR: Backport label for 2.9 label Aug 10, 2023

opensearch-trigger-bot bot mentioned this pull request Aug 10, 2023

[Backport 2.9] Add ML connector edits #4743

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ML connector edits #4636

Add ML connector edits #4636

Naarcha-AWS commented Jul 25, 2023

hdhalter left a comment

natebower left a comment

natebower Aug 10, 2023

natebower left a comment


		### Node settings

		Remote models based on external connectors consume less resources. Therefore, you can deploy any model from a standalone connector using data nodes. To make sure that your standalone connection uses data nodes, set `plugins.ml_commons.only_run_on_ml_node` to `false`, as shown in the following example:

Add ML connector edits #4636

Add ML connector edits #4636

Conversation

Naarcha-AWS commented Jul 25, 2023

Checklist

hdhalter left a comment

Choose a reason for hiding this comment

natebower left a comment

Choose a reason for hiding this comment

natebower Aug 10, 2023

Choose a reason for hiding this comment

natebower left a comment

Choose a reason for hiding this comment