-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Search Nodes Description in the Creating a Cluster Page #4597
Conversation
3f26e38
to
cbc0c37
Compare
Thanks, @augustoliks! @andrross Could you please review this PR for technical accuracy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@augustoliks A small rewording suggestion for clarity. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with noted changes.
46c19bd
to
e31f070
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @augustoliks! Let's get this merged.
* [DOC] fix the tabulation of searchable snapshots snippet example Signed-off-by: Carlos Neto <[email protected]>
…#4597) * [DOC] fix the tabulation of searchable snapshots snippet example Signed-off-by: Carlos Neto <[email protected]> (cherry picked from commit a1ac25a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#4597) (#4649) * [DOC] fix the tabulation of searchable snapshots snippet example (cherry picked from commit a1ac25a) Signed-off-by: Carlos Neto <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…opensearch-project#4597) * [DOC] fix the tabulation of searchable snapshots snippet example Signed-off-by: Carlos Neto <[email protected]> Signed-off-by: Shankaran <[email protected]>
…opensearch-project#4597) * [DOC] fix the tabulation of searchable snapshots snippet example Signed-off-by: Carlos Neto <[email protected]> Signed-off-by: Shankaran <[email protected]>
…opensearch-project#4597) * [DOC] fix the tabulation of searchable snapshots snippet example Signed-off-by: Carlos Neto <[email protected]>
…#4597) * [DOC] fix the tabulation of searchable snapshots snippet example Signed-off-by: Carlos Neto <[email protected]>
Search Node Description
There are no documented
search
Node type in the tuning-your-cluster/index/ Page.In my commit, I created a description based on Searchable Snapshots Feature Blog Post, and in the Documentation Page Searchable Snapshots
Fix the Searchable Snapshot Snippet Example
I found an error in the Searchable Snapshot example. It is a simple tabulation error.