Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search Nodes Description in the Creating a Cluster Page #4597

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

c-neto
Copy link
Contributor

@c-neto c-neto commented Jul 21, 2023

Search Node Description

There are no documented search Node type in the tuning-your-cluster/index/ Page.

In my commit, I created a description based on Searchable Snapshots Feature Blog Post, and in the Documentation Page Searchable Snapshots

drawing

Link: https://opensearch.org/docs/2.8/tuning-your-cluster/index/


Fix the Searchable Snapshot Snippet Example

I found an error in the Searchable Snapshot example. It is a simple tabulation error.

drawing

Link: https://opensearch.org/docs/2.8/tuning-your-cluster/availability-and-recovery/snapshots/searchable_snapshot/

@c-neto c-neto marked this pull request as draft July 21, 2023 01:40
@c-neto c-neto changed the title Add Search Nodes Description in the "Creating a cluster" Page Add Search Nodes Description in the Creating a Cluster Page Jul 21, 2023
@c-neto c-neto marked this pull request as ready for review July 21, 2023 01:52
@c-neto c-neto marked this pull request as draft July 21, 2023 11:59
@c-neto c-neto force-pushed the main branch 3 times, most recently from 3f26e38 to cbc0c37 Compare July 21, 2023 21:51
@c-neto c-neto marked this pull request as ready for review July 21, 2023 21:54
@kolchfa-aws
Copy link
Collaborator

Thanks, @augustoliks!

@andrross Could you please review this PR for technical accuracy.

@kolchfa-aws kolchfa-aws self-assigned this Jul 26, 2023
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@augustoliks A small rewording suggestion for clarity. Thanks.

_tuning-your-cluster/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with noted changes.

_tuning-your-cluster/index.md Outdated Show resolved Hide resolved
@c-neto c-neto force-pushed the main branch 2 times, most recently from 46c19bd to e31f070 Compare July 28, 2023 17:13
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @augustoliks! Let's get this merged.

* [DOC] fix the tabulation of searchable snapshots snippet example

Signed-off-by: Carlos Neto <[email protected]>
@kolchfa-aws kolchfa-aws merged commit a1ac25a into opensearch-project:main Jul 28, 2023
@kolchfa-aws kolchfa-aws added the backport 2.9 PR: Backport label for 2.9 label Jul 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 28, 2023
…#4597)

* [DOC] fix the tabulation of searchable snapshots snippet example

Signed-off-by: Carlos Neto <[email protected]>
(cherry picked from commit a1ac25a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this pull request Jul 28, 2023
…#4597) (#4649)

* [DOC] fix the tabulation of searchable snapshots snippet example


(cherry picked from commit a1ac25a)

Signed-off-by: Carlos Neto <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akashsha1 pushed a commit to akashsha1/documentation-website that referenced this pull request Aug 3, 2023
…opensearch-project#4597)

* [DOC] fix the tabulation of searchable snapshots snippet example

Signed-off-by: Carlos Neto <[email protected]>
Signed-off-by: Shankaran <[email protected]>
akashsha1 pushed a commit to akashsha1/documentation-website that referenced this pull request Aug 7, 2023
…opensearch-project#4597)

* [DOC] fix the tabulation of searchable snapshots snippet example

Signed-off-by: Carlos Neto <[email protected]>
Signed-off-by: Shankaran <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
…opensearch-project#4597)

* [DOC] fix the tabulation of searchable snapshots snippet example

Signed-off-by: Carlos Neto <[email protected]>
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
…#4597)

* [DOC] fix the tabulation of searchable snapshots snippet example

Signed-off-by: Carlos Neto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.9 PR: Backport label for 2.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants