Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search pipeline metrics to Nodes Stats API #4548

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

kolchfa-aws
Copy link
Collaborator

Fixes #4511

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kolchfa-aws kolchfa-aws self-assigned this Jul 12, 2023
@kolchfa-aws kolchfa-aws added v2.9.0 release-notes PR: Include this PR in the automated release notes labels Jul 12, 2023
@kolchfa-aws
Copy link
Collaborator Author

@noCharger This PR is ready for tech review. Thanks!

Signed-off-by: Fanit Kolchina <[email protected]>
Copy link
Contributor

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes. LGTM

@kolchfa-aws kolchfa-aws added the 5 - Editorial review PR: Editorial review in progress label Jul 13, 2023
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws Just three comments :-)

_api-reference/nodes-apis/nodes-stats.md Outdated Show resolved Hide resolved
_api-reference/nodes-apis/nodes-stats.md Outdated Show resolved Hide resolved
_api-reference/nodes-apis/nodes-stats.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws added 3 - Done Issue is done/complete and removed 5 - Editorial review PR: Editorial review in progress labels Jul 13, 2023
@kolchfa-aws kolchfa-aws merged commit f0b8660 into main Jul 13, 2023
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
* Add search pipeline metrics to Nodes Stats API

Signed-off-by: Fanit Kolchina <[email protected]>

* Add note about tags

Signed-off-by: Fanit Kolchina <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

* Add a sentence about expanding the response

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
* Add search pipeline metrics to Nodes Stats API

Signed-off-by: Fanit Kolchina <[email protected]>

* Add note about tags

Signed-off-by: Fanit Kolchina <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

* Add a sentence about expanding the response

Signed-off-by: Fanit Kolchina <[email protected]>

---------

Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
@Naarcha-AWS Naarcha-AWS deleted the nodes-pipeline-metrics branch March 28, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Search Pipeline Metrics
4 participants