-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document limits to index and bulk pages #4537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added
3 - Tech review
PR: Tech review in progress
release-notes
PR: Include this PR in the automated release notes
labels
Jul 10, 2023
Naarcha-AWS
requested review from
cwillum,
hdhalter,
kolchfa-aws,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
July 10, 2023 18:09
Naarcha-AWS
changed the title
Add document limits to index and buld pages
Add document limits to index and bulk pages
Jul 13, 2023
Naarcha-AWS
commented
Jul 18, 2023
Naarcha-AWS
commented
Jul 18, 2023
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added
4 - Doc review
PR: Doc review in progress
and removed
3 - Tech review
PR: Tech review in progress
labels
Jul 18, 2023
Naarcha-AWS
commented
Jul 18, 2023
Naarcha-AWS
commented
Jul 18, 2023
Signed-off-by: Naarcha-AWS <[email protected]>
natebower
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with noted changes. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
ankitkala
reviewed
Aug 2, 2023
@@ -16,6 +16,8 @@ You index data using the OpenSearch REST API. Two APIs exist: the index API and | |||
|
|||
For situations in which new data arrives incrementally (for example, customer orders from a small business), you might use the index API to add documents individually as they arrive. For situations in which the flow of data is less frequent (for example, weekly updates to a marketing website), you might prefer to generate a file and send it to the `_bulk` API. For large numbers of documents, lumping requests together and using the `_bulk` API offers superior performance. If your documents are enormous, however, you might need to index them individually. | |||
|
|||
When indexing documents, the document `_id` must be 512 MB or less in size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Naarcha-AWS, the doc ID limit is 512 bytes(not MB)
4 tasks
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
* Add document limits to index and buld pages Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Add document limits to index and buld pages Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - Doc review
PR: Doc review in progress
release-notes
PR: Include this PR in the automated release notes
v2.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4391
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.