-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geohash, geotile, and geobounds aggregation on geoshapes documentation #4517
Conversation
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
@navneet1v I've verified all requests against the endpoint you provided and they all work. Could you review this PR for technical accuracy please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One change
Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
|
||
## Aggregating geoshapes | ||
|
||
To aggregate on geoshape fields, first create an index and map the `location` field as a `geo_shape`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"To run an aggregation on a geoshape field"?
@@ -8,7 +8,7 @@ nav_order: 80 | |||
|
|||
# Geohash grid aggregations | |||
|
|||
The `geohash_grid` aggregation buckets documents for geographical analysis. It organizes a geographical region into a grid of smaller regions of different sizes or precisions. Lower values of precision represent larger geographical areas and higher values represent smaller, more precise geographical areas. | |||
The `geohash_grid` aggregation buckets documents for geographical analysis. It organizes a geographical region into a grid of smaller regions of different sizes or precisions. Lower values of precision represent larger geographical areas and higher values represent smaller, more precise geographical areas. You can aggregate documents on [geopoint]({{site.url}}{{site.baseurl}}/opensearch/supported-field-types/geo-point/) or [geoshape]({{site.url}}{{site.baseurl}}/opensearch/supported-field-types/geo-shape/) fields using a geohash grid aggregation. One notable difference is that a geopoint is only present in one bucket, but a geoshape is counted in all geohash grid cells with which it intersects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"You can run a document aggregation on a geopoint or geoshape field..."?
## Aggregating geoshapes | ||
|
||
To aggregate on geoshape fields, first create an index and map the `location` field as a `geo_shape`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"To run an aggregation on a geoshape field"?
{% include copy-curl.html %} | ||
|
||
The optional `wrap_longitude` parameter specifies whether the bounding box returned by the aggregation can overlap the international date line (180° meridian). If `wrap_longitude` is set to `true`, the bounding box can overlap the international date line and return a bounds where the lower-left longitude is larger than the upper-right longitude. The default value for `wrap_longitude` is `true`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"return a bounds" reads oddly to me. Do we mean "return boundaries"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworded
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
…ation (opensearch-project#4517) * Add geohash and geotile grid aggregation on geoshapes documentation Signed-off-by: Fanit Kolchina <[email protected]> * Add copy buttons and details blocks Signed-off-by: Fanit Kolchina <[email protected]> * Add note about geoshape agg not supported for visualizations Signed-off-by: Fanit Kolchina <[email protected]> * Update _query-dsl/aggregations/bucket/geohash-grid.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Add editorial comments Signed-off-by: Fanit Kolchina <[email protected]> * Reworded bounds Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
…ation (#4517) * Add geohash and geotile grid aggregation on geoshapes documentation Signed-off-by: Fanit Kolchina <[email protected]> * Add copy buttons and details blocks Signed-off-by: Fanit Kolchina <[email protected]> * Add note about geoshape agg not supported for visualizations Signed-off-by: Fanit Kolchina <[email protected]> * Update _query-dsl/aggregations/bucket/geohash-grid.md Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Add editorial comments Signed-off-by: Fanit Kolchina <[email protected]> * Reworded bounds Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Fixes #861
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.