Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Add Observability changes #443

Merged
merged 2 commits into from
Mar 17, 2022
Merged

[1.3] Add Observability changes #443

merged 2 commits into from
Mar 17, 2022

Conversation

Naarcha-AWS
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS commented Mar 14, 2022

Signed-off-by: Naarcha-AWS [email protected]

Description

This change adds all Observability changes for 1.3.

Currently, we do not a PPL functions section. We'll need to add a PPL specific functions section that matches the content found in the OpenSearch repo https://github.com/opensearch-project/sql/tree/main/docs/user/ppl/functions. See issue #442 for details.

Issues Resolved

Fixes #441

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner March 14, 2022 17:56
@Naarcha-AWS
Copy link
Collaborator Author

@joshuali925: Mind giving this a quick review?

@Naarcha-AWS Naarcha-AWS changed the title [1.3]: Add observibility changes [1.3]: Add Observability changes Mar 14, 2022
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@keithhc2 keithhc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks.

_observability-plugin/ppl/commands.md Outdated Show resolved Hide resolved
_observability-plugin/ppl/commands.md Outdated Show resolved Hide resolved
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS added upcoming release Don't merge until the version or feature is available v1.3.0 Issue: Any issues related to version v1.3.x labels Mar 14, 2022
@Naarcha-AWS Naarcha-AWS changed the title [1.3]: Add Observability changes [1.3] Add Observability changes Mar 14, 2022
@Naarcha-AWS Naarcha-AWS merged commit 8088572 into main Mar 17, 2022
@Naarcha-AWS Naarcha-AWS deleted the observe-ppl-1.3 branch March 17, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upcoming release Don't merge until the version or feature is available v1.3.0 Issue: Any issues related to version v1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update SQL/PPL docs for 1.3
4 participants