-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates based on feedback in Slack and doc website #4304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heather Halter <[email protected]>
hdhalter
requested review from
cwillum,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
June 13, 2023 01:21
@bbarani - feel free to add anything you think is missing based on the user's feedback. Thanks! |
cwillum
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
Signed-off-by: Heather Halter <[email protected]> (cherry picked from commit f7b5980) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hdhalter
pushed a commit
that referenced
this pull request
Jun 13, 2023
(cherry picked from commit f7b5980) Signed-off-by: Heather Halter <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
Jun 14, 2023
Signed-off-by: Heather Halter <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
Aug 24, 2023
Signed-off-by: Heather Halter <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
vagimeli
added a commit
that referenced
this pull request
Aug 24, 2023
This reverts commit c84983f. Signed-off-by: Melissa Vagi <[email protected]>
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Heather Halter <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
Signed-off-by: Heather Halter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a comment about this being incorrect in the public slack and we also got a comment in our documentation feedback mechanism.
Changed 'network.host' to 'network.bind_host'
Issues Resolved
na
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.