Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates based on feedback in Slack and doc website #4304

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

hdhalter
Copy link
Contributor

Description

There was a comment about this being incorrect in the public slack and we also got a comment in our documentation feedback mechanism.

Changed 'network.host' to 'network.bind_host'

Issues Resolved

na

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Heather Halter <[email protected]>
@hdhalter
Copy link
Contributor Author

@bbarani - feel free to add anything you think is missing based on the user's feedback. Thanks!

@hdhalter hdhalter self-assigned this Jun 13, 2023
@hdhalter hdhalter added the 4 - Doc review PR: Doc review in progress label Jun 13, 2023
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdhalter hdhalter merged commit f7b5980 into main Jun 13, 2023
@hdhalter hdhalter added the backport 2.8 PR: Backport label for 2.8 label Jun 13, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 13, 2023
Signed-off-by: Heather Halter <[email protected]>
(cherry picked from commit f7b5980)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hdhalter pushed a commit that referenced this pull request Jun 13, 2023
(cherry picked from commit f7b5980)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Jun 14, 2023
Signed-off-by: Heather Halter <[email protected]>
vagimeli added a commit that referenced this pull request Jun 15, 2023
This reverts commit c84983f.
vagimeli pushed a commit that referenced this pull request Aug 24, 2023
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
vagimeli added a commit that referenced this pull request Aug 24, 2023
This reverts commit c84983f.

Signed-off-by: Melissa Vagi <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
Signed-off-by: Heather Halter <[email protected]>
@hdhalter hdhalter deleted the network.bind_host branch March 28, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.8 PR: Backport label for 2.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants