-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for API rate limiting #4287
Conversation
Signed-off-by: cwillum <[email protected]>
|
||
| Setting | Description | | ||
| :--- | :--- | | ||
| `opensearch_security.ui.openid.login.buttonname` | Display name for the login button. "Log in with single sign-on" by default. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DarshitChanpura Just in a draft state right now. I'll keep you posted. (and the answer is no. Just getting a table in there.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DarshitChanpura I believe this is all set. When you get a chance, could you have a last look? Thanks for all the help with this.
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwillum Looks good. A couple of suggestions for clarity.
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
* fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> --------- Signed-off-by: cwillum <[email protected]> (cherry picked from commit 9a8995d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit * fix#4171 api rate limit --------- (cherry picked from commit 9a8995d) Signed-off-by: cwillum <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> --------- Signed-off-by: cwillum <[email protected]>
* fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
This reverts commit aebbf6a. Signed-off-by: Melissa Vagi <[email protected]>
* fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> * fix#4171 api rate limit Signed-off-by: cwillum <[email protected]> --------- Signed-off-by: cwillum <[email protected]>
Description
Rate limiting is configured in the
config.yml
file for security. This configuration needs to be documented.Issues Resolved
Did the above.
Fixes #4171
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.